Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Menus/buttons not working on maxthon/linux #111

Closed
burp opened this issue Dec 31, 2013 · 3 comments
Closed

Menus/buttons not working on maxthon/linux #111

burp opened this issue Dec 31, 2013 · 3 comments

Comments

@burp
Copy link

burp commented Dec 31, 2013

Hi,

since 0.7.2.0 neither the menu button nor the domain filter selector work on maxthon for linux ( which you can get http://dl.maxthon.com/mx_linux/package/maxthon-0.9.0.21-x86_64.tgz here or http://dl.maxthon.com/mx_linux/package/maxthon-0.9.0.21-i386.tgz for 32bit ). Before 0.7.2.0 just the domain name filter selector button did not work.

I hope you can support this chromium fork too :)

@gorhill
Copy link
Owner

gorhill commented Jan 1, 2014

For the record, the difference with the previous version is that now the buttons are handled on mousedown event instead of click, so clearly there is something about mousedown event which maxthon doesn't like (because I wanted to avoid javascript to handle drop down menus). I don't know when I will have time to look at this though. If you know any developer with the proper knowledge who can look into this that would be great (the code to look at is in the js/popup.js file).

@gorhill gorhill closed this as completed in 3326220 Jan 1, 2014
@gorhill
Copy link
Owner

gorhill commented Jan 1, 2014

I actually didn't test the fix (I didn't want to install the browser), but I don't see why the fix would not work, as I don't use the flaky css-focus technique. If you can confirm the fix work that would be great.

@burp
Copy link
Author

burp commented Jan 1, 2014

Fix confirmed as working :) Thanks!

gorhill added a commit that referenced this issue Jan 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants