Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Ability to make global rules #115

Closed
insanitybit opened this issue Jan 1, 2014 · 3 comments
Closed

Ability to make global rules #115

insanitybit opened this issue Jan 1, 2014 · 3 comments
Milestone

Comments

@insanitybit
Copy link

I realize that we can make * / * * rules but once you choose a website to be domain or site specific it removes those rules.

In certain cases, such as when a third party (wp.com) is very common on a lot of websites, it may make sense to have them globally allowed even on a site with a more specific ruleset.

@gorhill
Copy link
Owner

gorhill commented Jan 2, 2014

Related to #105.

@gorhill
Copy link
Owner

gorhill commented Jan 2, 2014

I realize that we can make * / * * rules

Just to clarify, what do you mean by * / * *?

Edit: Ok I get it, this refers to making rules in global scope.

@gorhill
Copy link
Owner

gorhill commented Jan 12, 2014

In the next release, global rules will be copied into the scope at scope-creation time. I do realize it is not as nice as having rules in global scope also apply in local scope. I fear rule bloat if someone has a lot of rules in the global scope (very likely since easy creation of site-scope is recent), which are going to be copied into each scope. I actually mitigate this by filtering whitelist rules only to those which are seen in the target web page at copy time, while blacklist/graylist rules are all copied.

As discussed elsewhere, there are complications in having inheritance between scopes. As it is now, for any cell in the matrix, the allow/block state is guaranteed to be resolved when the evaluation reaches the cell *|* in the matrix (the "all" cell, which cannot be graylisted).

However, admittedly the preset blocked hosts do propagate to narrower scopes. So it's like we could have a set of universe-scoped rules which are seen by all scopes (global * included) without having to copy them, just like the preset blocked hosts (from the 3rd-party lists) are seen from everywhere.

@ghost ghost assigned tailHey Jan 29, 2014
@gorhill gorhill modified the milestones: 0.3.3, 0.8.6.0 Apr 4, 2014
@gorhill gorhill closed this as completed in 1c9eadb Apr 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants