Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Scope precedence or import global rules into current set #105

Closed
Tasqa opened this issue Dec 27, 2013 · 6 comments
Closed

Scope precedence or import global rules into current set #105

Tasqa opened this issue Dec 27, 2013 · 6 comments

Comments

@Tasqa
Copy link

Tasqa commented Dec 27, 2013

I have defined a global allowance for certain youtube features to get it working without cookies. But if I create a site specific filter I have to re-create those same youtube rules for each site/domain.

Wouldn't it be easier if you can hit a checkmark to import global rules in the current context? Be it in settings or in the popup on a site specific base.

@gorhill
Copy link
Owner

gorhill commented Dec 27, 2013

Yes, I was really undecided whether I should copy rules from the global scope by default. In the end I went with laziness and decided to let the user start from scratch. I think simply copying whatever global rules are applicable to the current state of the matrix when the scope is create the first time would be a good default -- rather than have yet another button/setting which requires explanation etc.

@Tasqa
Copy link
Author

Tasqa commented Dec 27, 2013

That sounds like a reasonable default! :-)

On Fri 27 Dec 2013 03:54:50 PM CET, Raymond Hill wrote:

Yes, I was really undecided whether I should copy rules from the
global scope by default. In the end I went with laziness and decided
to let the user start from scratch. I think simply copying whatever
global rules are applicable to the current state of the matrix when
the scope is selected would be a good default -- rather than have yet
another button/setting which requires explanation etc.


Reply to this email directly or view it on GitHub
#105 (comment).

@gorhill
Copy link
Owner

gorhill commented Jan 14, 2014

Fixed in 17974e0 (rules are copied from broader scopes at scope creation time)

@gorhill gorhill closed this as completed Jan 14, 2014
@Tasqa
Copy link
Author

Tasqa commented Apr 20, 2014

This does not seem to happen with the auto-site-scope creation option. Is this a bug?

@gorhill
Copy link
Owner

gorhill commented Apr 20, 2014

The rules from global scope are no longer copied since users can now create their own ubiquitous rules (see Ubiquitous rules tab in the dashboard). That's the most efficient approach for these hostnames a user wants to blacklist or whitelist in all scopes, as copying lead to duplicate and data bloat.

Edit: Just to give an example of "data bloat", imagine prior to the ability for a user to create his own ubiquitously blacklisted hostnames, all blacklisted hostnames from * scope where copied in each newly created scope, including those hostnames which are irrelevant to the web page for which the scope is created (because HTTPSB can't know beforehand whether they are relevant or not). So the copy of blacklisted hostnames was really a temporary workaround until I implemented the user-supplied ubiquitous hostnames feature.

@Tasqa
Copy link
Author

Tasqa commented Apr 20, 2014

Ah ok, works as expected. Thanks!

On zo, apr 20, 2014 at 5:44 , Raymond Hill notifications@github.com
wrote:

The rules from global scope are no longer copied since users can now
create their own ubiquitous rules (see Ubiquitous rules tab in the
dashboard). That's the most efficient approach for these hostnames a
user wants to blacklist or whitelist in all scopes, as copying lead
to duplicate and data bloat.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants