Prevent the creation of non-cosmetic extended filters in element picker

Related issue: - uBlockOrigin/uBlock-issues#2232
gorhill · Nov 19, 2022 · 4475305 · 4475305
1 parent 86c8023
commit 4475305
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/js/epicker-ui.js b/src/js/epicker-ui.js
@@ -113,11 +113,10 @@ const filterFromTextarea = function() {
     const sfp = staticFilteringParser;
     sfp.analyze(filter);
     sfp.analyzeExtra();
-    if (
-        sfp.category !== sfp.CATStaticExtFilter &&
-        sfp.category !== sfp.CATStaticNetFilter ||
-        sfp.shouldDiscard()
-    ) {
+    if ( sfp.shouldDiscard() ) { return '!'; }
+    if ( sfp.category === sfp.CATStaticExtFilter ) {
+        if ( sfp.hasFlavor(sfp.BITFlavorExtCosmetic) === false ) { return '!'; }
+    } else if ( sfp.category !== sfp.CATStaticNetFilter ) {
         return '!';
     }
     return filter;