Skip to content

Commit

Permalink
Remove experimental click-to-load disqus scriptlets
Browse files Browse the repository at this point in the history
As per AMO reviewer:

> We will need you to remove the remote scripts in
>
> web_accessible_resources\disqus_embed.js - line 48
> web_accessible_resources\disqus_forums_embed.js - line 44

Related issue:
- #1899
  • Loading branch information
gorhill committed Aug 6, 2020
1 parent c892718 commit 7c22a31
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 110 deletions.
58 changes: 0 additions & 58 deletions src/web_accessible_resources/disqus_embed.js

This file was deleted.

52 changes: 0 additions & 52 deletions src/web_accessible_resources/disqus_forums_embed.js

This file was deleted.

2 comments on commit 7c22a31

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need you to remove the remote scripts in

No reason given ?

@gorhill
Copy link
Owner Author

@gorhill gorhill commented on 7c22a31 Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can understand the reason. Summarily, the code is too confusing to follow to figure out what script is going to be loaded ultimately. This was added years ago as a preliminary experimentation to support a click-to-load feature. This can be better implemented in a way that is not ambiguous, so for now people will have to wait for the feature to be officially implemented, the experimental way has never be the proper way.

Please sign in to comment.