Skip to content

Commit

Permalink
Make the logger entry dialog modeless
Browse files Browse the repository at this point in the history
  • Loading branch information
@gorhill
gorhill committed Jan 4, 2023
1 parent c889747 commit a9405fe
Show file tree
Hide file tree
Showing 5 changed files with 248 additions and 147 deletions.
2 changes: 1 addition & 1 deletion src/css/common.css
View file
Expand Up @@ -85,7 +85,7 @@ button {
color: var(--button-ink);
display: inline-flex;
fill: var(--button-ink);
font-size: 14px;
font-size: var(--font-size);
justify-content: center;
min-height: 36px;
padding: 0 var(--font-size);
Expand Down

6 comments on commit a9405fe

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill Clicking on "partyness" column in the logger does nothing anymore.

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above issue now fixed in 1.46.1b6 but another regression is the netFilteringDialog appears to the extreme right section of the logger page after being invoked, it used to be in the centre before.

@gorhill
Copy link
Owner Author

@gorhill gorhill commented on a9405fe Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you see this as a regression? At some point you have to allow my design choices.

@uBlock-user
Copy link
Contributor

@uBlock-user uBlock-user commented on a9405fe Jan 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you saw that as a design choice. Being used to seeing the dialog appear in the centre and now suddenly starts appearing in the extreme right corner is something that causes issue for me as now I have to bring it back to the centre as that position is not comfortable and I have to do that everytime I open the logger too. I don't see you documenting the change in location either, so it became obvious to me that it must be a regression. I never disallowed your design choices, so why do you think I'm disallowing you from making a design choice ?

@gorhill
Copy link
Owner Author

@gorhill gorhill commented on a9405fe Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just explain why the new way creates an issue to you. I don't see issue on my side given how I work with the logger, so merely calling this a regression without explaining why it is one to you, I won't understand and relate.

@uBlock-user
Copy link
Contributor

@uBlock-user uBlock-user commented on a9405fe Jan 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as now I have to bring it back to the centre as that position is not comfortable and I have to do that everytime I open the logger too.

Everytime the dialog appears in the extreme right, my eyes need to move to that location and then read the information, which is not comfortable to me and so I bring it back to the centre, read the information and close it back and then close the logger and then when I need to do it back, I again have to go through that annoyance and bring it back to the centre, because the position doesn't get saved either.

Please sign in to comment.