-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do let grow subframe dictionary grow unbound
Related discussion: - https://bugzilla.mozilla.org/show_bug.cgi?id=1652925 It's not clear the code here will fix the reported issue, but I did identify that the subframe dictionary of a very long-lived web page can theoretically grow unbound.
- Loading branch information
Showing
2 changed files
with
36 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh... Should be "Do not let...".
feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is the root cause?
PageStore
doesn't store favicons, right? Also, when the tab is closed, it should remove the entirepageStores
map entry, which should free the memory. The frame dictionary problem is known for years (jspenguin2017/uBlockProtector#799), but I never saw any actual issues that are caused by it.Also, you can use
http://nowhere.test/
or something for the test page (cf31d83), it doesn't have to fully load for extensions to be notified about the new frames.feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the bugzilla issue I say:
feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It smells like a browser bug to me.
feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't know about that trick.
feabfe3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://nowhere.invalid/
works too, bothtest
andinvalid
are reserved TLDs:https://en.wikipedia.org/wiki/.test
https://en.wikipedia.org/wiki/.invalid