-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger: Popup which shows the used filter is empty #2179
Comments
Fixed in #1691 |
This was fixed in dev build. |
I can confirm in Fx 52 uBO 1.9.17rc0 |
@gwarser Did you click on an old Reek's-related log entry after disabling Reek's? |
Yes, |
Not something that can be fixed -- uBO reverse lookup filters in memory only -- there is no use case for disabling a filter list and investigating the logger for filters no longer in effect. |
Oh, I actually meant that when I created this thread. Wouldn't it make sense then to remove the possibility to investigate for a filter list, which is no longer in effect? As it is now, it's confusing |
I did not read carefully, I missed this, I had assumed it was related to the solved issue. Sorry. Yes, a meaningful message could be displayed. |
Logger overlay is also empty when cosmetic filter starts with dot. I found a lot of these invalid filters in 'Popup Blocker PLUS ( PL )', reported: |
|
It's not only invalid filters.
Not sure why they use hex replacement for underscore. If it is an error in the list (although blocking works) it would be nice to know what list that item is on when it pops up in the logger. However, it looks intentional because if class/ID begins with underscore, it is always replaced by First variation shows empty overlay, second works as intended. Firefox 55.0.3 + uBO 1.13.8 /editThe reason they use the escaped underscore is because W3C recommendation says leading However using Hex is absolutely allowed in CSS, usually just no one uses it. So you can have different representations for the same object. |
I made this patch that fixes the blank dialog box. (Note the TODO for making it a proper i18n message.) Clicking on a rule not found shows this: It's easy to verify - use methods mentioned before or just comment out one of your own rules after loading the relevant page with the logger open (so the rule is logged, of course). I then toggle the rule enable/disable several times, and the dialog box was correct found/not found each time. |
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Describe the issue
Clicking on an blocked item on the logger page opens an overlay which shows the filter list in question.
After disabling that filter list and reloading the page, you can still click on the logger page on the item which was blocked before the reload.
However, now the overlay is empty.
Screenshot in which the issue can be seen
Steps for anyone to reproduce the issue
e.g.
http://www.continental-reifen.de/fahrrad/service/faq/montagehinweise
Your settings
Your filter lists
Default
Suggestion
disable the possibility of clicking on an blocked item where's no filter list known
keep the filter list stored and show them even after a reload
The text was updated successfully, but these errors were encountered: