Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between ABP and uBO over FETCH (json) #2226

Closed
k2jp opened this issue Dec 8, 2016 · 5 comments
Closed

Incompatibility between ABP and uBO over FETCH (json) #2226

k2jp opened this issue Dec 8, 2016 · 5 comments

Comments

@k2jp
Copy link

k2jp commented Dec 8, 2016

Thank you for maintaining uBO!

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

done

Describe the issue

FETCH requests are blocked after |http:$ping is added.

One or more specific URLs where the issue occurs

http://www.compareyourcountry.org/pisa/?lg=en (JavaScript is required)

Screenshot in which the issue can be seen

BEFORE |http:$ping is added
Developer ToolsFETCH (json)

AFTER |http:$ping is added
uBO loggerother (blocked)

ABP blockable items$xmlhttprequest (not blocked)

Steps for anyone to reproduce the issue

  1. Install and Disable uBlock Origin 1.10.0 and Adblock Plus 2.8.2.
  2. Open http://www.compareyourcountry.org/pisa/?lg=en
  3. Use Firefox 50.0.2 build-in developer tools via Web DeveloperNetwork and confirm that /maps.js? requests belong to FETCH (json) after you reload the page.
  4. Enable uBlock Origin and add |http:$ping.
  5. Open the Logger and reload the page.
  6. Confirm that /maps.js? requests belong to other and are blocked. This result is unexpected for me.
  7. Disable uBlock Origin
  8. Enable Adblock Plus and add |http:$ping.
  9. Open Blockable Items and reload the page.
  10. Confirm that /maps.js? requests belong to xmlhttprequest and are NOT blocked.
  • You notice that...

    • uBlock Origin interprets |http:$ping as |http:$other.
    • uBlock Origin treats FETCH as other.
      These deference causes incompatibility.
  • Note: I know that uBlock Origin has a setting "Disable hyperlink auditing/beacon" and $ping filter option is dispensable. However, it would be nice if this incompatibility is fixed!

Your settings

  • OS: Windows
  • Browser: Cyberfox 50.0.2 (Firefox 50.0.2 compatible) JavaScript enabled
  • uBlock Origin 1.10.0
  • Adblock Plus 2.8.2
Your filter lists

This issue is not depend on specific filter lists.

Your custom filters (if any)

|http:$ping

@gorhill gorhill closed this as completed in 4a4de32 Dec 8, 2016
@gorhill gorhill reopened this Dec 8, 2016
@gorhill
Copy link
Owner

gorhill commented Dec 8, 2016

uBO will map Firefox's TYPE_FETCH to xmlhttprequest (xhr in logger), that is a quick fix. uBO 1.10.1rc1 on AMO has that fix.

The other part, support for ping filter, I will implement it eventually.

@k2jp
Copy link
Author

k2jp commented Dec 8, 2016

Confirmed the fix. Many thanks!

uBO 1.10.1rc1

Support for ping

Understood.

@k2jp k2jp closed this as completed Dec 8, 2016
@k2jp
Copy link
Author

k2jp commented Dec 8, 2016

Reopened for the ping support.

@k2jp k2jp reopened this Dec 8, 2016
@gorhill
Copy link
Owner

gorhill commented Dec 8, 2016

Actually, there is already an issue for ping, I reopened this one as the substance of the issue here was missing mapping between TYPE_FETCH and xmlhttprequest in Firefox.

@gorhill gorhill closed this as completed Dec 8, 2016
@k2jp
Copy link
Author

k2jp commented Dec 8, 2016

Understood.
Thanks for the explanation.

gorhill added a commit to gorhill/uMatrix that referenced this issue Feb 4, 2017
Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants