Firefox full review feedback

[gorhill]

Opening a meta issue to keep track of the process and related code changes, etc.

All these changes will also need to be imported in uMatrix too, which I also have submitted for full review.

[gorhill]

2015-05-27:

1. Synchronous SQL should not be used. The use of synchronous SQL via the storage system leads to severe responsiveness issues, and should be avoided at all costs. Please use asynchronous SQL via Sqlite.jsm (http://mzl.la/sqlite-jsm) or the executeAsync method, or otherwise switch to a simpler database such as JSON files or IndexedDB.
2. SQL statements should be static strings. Dynamic SQL statement should be constucted via static strings, in combination with dynamic parameter binding via Sqlite.jsm wrappers (http://mzl.la/sqlite-jsm) or createAsyncStatement (https://developer.mozilla.org/en-US/docs/Storage#Binding_parameters)

Fixed with 53fc106 (0.9.8.1).

[gorhill]

2015-05-28:

1. After installing I got in the Browser Console following error:
   NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [mozIStorageConnection.createStatement] vapi-background.js:234:0 (
   (chrome//ublock/content/js/vapi-background.js)

I could not reproduce, however I revised the code using API doc to harden SQLite code: c285ace (0.9.8.2, not submitted yet).

I tested the code against abnormal conditions by using restrictive r/w permissions on the sqlite file, and uBlock functioned properly (except for not being able to read and/or write settings of course).

[5t3f4n]

I see both uBlock Origin and uMatrix are up on AMO and at their respective latest versions.
Keep us updated on the review process.

Btw, do the GitHub versions now auto-update to the AMO ones? Or have you changed your mind on updating directly from GitHub?

[gorhill]

uBlock Origin was fully reviewed on July 4th, 2015.