Static filters not working with urls containing Unicode chars

[gomoku]

An example static filter: ||darmoweogłoszenia.pl/pl-mapa.js$script,domain=www.xn--darmoweogoszenia-ryc.pl
(as well it's simplified case: ||darmoweogłoszenia.pl/pl-mapa.js$script)
not working, no red blocked script is showing up in the logger

Reproduced on FF 55.0.3 32bit / FF Nightly 56.0b8 64bit / Opera 47.0.2631.71 64bit (PGO) + uBO v1.13.10 / 1.14.3b0 webext / v1.14.4 webext.

(not sure if a second part of a title of the issue is right, please correct me if needed)

[gorhill]

Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=945240

[gomoku]

From: https://github.com/gorhill/uBlock/releases/tag/1.14.5rc0

Firefox: The issue affects Firefox 55 only, it was fixed in Firefox 56.

I'm wondering how it could be fixed in 56, since as I've already mentioned in the 1st comment, I could and still can reproduce on:

FF Nightly 56.0b8 64bit

• as for FF 55.0.3 32bit + uBO v1.14.5rc0 it is fixed, and
• as for Opera 47.0.2631.71 64bit (PGO) + uBO v1.14.5.100 it is fixed too, along with the blank white box cosmetic filter issue btw

[gorhill]

The bugzilla issue says "firefox56 fixed", and the release notes for FF56 says it's fixed.

The issue I originally opened as been closed as wontfix because the bugzilla issue above was going to take care of it as a consequence of fixing it.

I don't have Firefox 56, but I can at least confirm it's fixed in Firefox 57.

I can enable the fix to apply to 56, but since it involves adding an overhead, I rather avoid it if it's unecessary. We have to find out whether the issue will be really solved once 56 lands.

[gorhill]

With Firefox 56, are the URLs reported in the logger punycoded or are they still IDN? They should all be normalized to punycode.

[gomoku]

will be really solved once 56 lands.

Yes, that's the point, shouldn't "resolved fixed" status actually mean that it has really already been fixed in the current 56 Nightly? I've just thought logically that fixed = actually physically fixed, not virtually.

Hmmm.... from https://bugzilla.mozilla.org/show_bug.cgi?id=945240:

Platform: Mac OS X

Now I'm confused if it is / will be fixed in FF 56 for Windows.

[gorhill]

I will see later today when I have to time if I can reproduce, I will download a temp copy of FF56 from the ftp server.

[gomoku]

OK.

With Firefox 56, are the URLs reported in the logger punycoded or are they still IDN? They should all be normalized to punycode.

IDN.

[gomoku]

Confirmed fixed.

[xofe]

The bugzilla issue says "firefox56 fixed", and the release notes for FF56 says it's fixed.

It seems the changes in bug 945240 are controlled by the network.standard-url.punycode-host pref (set to false in v56). The pref was then enabled in bug 1380617 (fixed in v57) along with fixes for broken behaviour.