Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock doesn't work properly with "Medium Security" in Tor browser 7.0.7 #3156

Closed
bup4gr opened this issue Oct 21, 2017 · 18 comments
Closed

Comments

@bup4gr
Copy link

bup4gr commented Oct 21, 2017

In Tor browser 7.0.7 ublock don't work if security level is set to medium or high.

To reproduce bug:

  • in tor browser (onion icon) set the security level medium or high
  • close tor browser
  • open tor browser
  • Ublock don't work properly

Problems:

  • Ublock don't filter, request blocked is always zero (and you cannot see the number of filter items in ublock icon)
  • if you go in list of filters and click on a filter, you cannot see the filter rules
  • in register of requests, you can see only few requests
@gorhill
Copy link
Owner

gorhill commented Oct 21, 2017

What version of uBO? (mind CONTRIBUTING please).

@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

Ublock 1.14.14

@gorhill
Copy link
Owner

gorhill commented Oct 21, 2017

Was this not happening with the previous version of the Tor Browser, or is it just the first time you happened to notice it?

The fix here will make uBO load properly the filter lists, but it will need to do it from scratch at every launch, and this means the filter lists will need to be all updated at every launch, because medium "Security Settings" and above does not allow the use of indexedDB, where UBO caches the filter lists and their compiled versions.

@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

The first time i notice it, is with tor browser 7.0.7. When i have 7.0.6 i have no problems. I also think a problem with the update from 7.0.6, but i have the same problem also with a clean installation of 7.0.7.

If i close tor browser with high in security setting and reopen it, i cannot update the filter list.
Also if i click on update button in ublock, then update of filter lists don't work.

@gorhill gorhill changed the title Ublock don't work properly with Tor browser 7.0.7 uBlock doesn't work properly with "Medium Security" in Tor browser 7.0.7 Oct 21, 2017
@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

For me the problem is not solved with ublock 1.14.16.

With "security settings" low:

  • all works
  • on bing i see
    u1

With "security settings" medium:

  • i cannot update the filters in the list
  • look like no filter works (see image, but in the register of requests there are some blocked connections)
  • on bing i see:
    u2

@gorhill
Copy link
Owner

gorhill commented Oct 21, 2017

I could reproduce the original issue. I identified that the opening of the indexedDB database silently failed. This is what I have fixed. I can no longer reproduce the issue:

a

You will have to investigate on your side to figure out what is your new issue. If I can't reproduce something, I can't investigate it.

@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

On my side i don't see any change from ublock 1.14.14 to 1.14.16. For me the problem is always the same.
I have a clean installation of Tor Browser 7.0.7 (installed today) on Windows 10, so in my opinion is not a particular setting that cause the problem.

Here there is what i see in browser console after that Tor browser start:
1

Now, how can i investigate the problem?

@gorhill
Copy link
Owner

gorhill commented Oct 21, 2017

In medium security, the filter lists will take significantly longer to load into memory, because uBO is forbidden to use indexedDB to cache the filter lists.

Are you waiting long enough to be sure the filter lists are all loaded before testing?

@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

When security level in not low, Tor browser take more time to load. Also after the complete load of Tor browser i wait 1 min, but the i have always the problem.

At the same time i have:
filters seems don't work (also if filter don't work is strange that domains connected is 0 of 1)
2
filters seem work
3

And somethnig that for me is unclear:
total filters are 59560, but only easylist is 76612 (this also after 5 min after open the browser)
4

@gorhill
Copy link
Owner

gorhill commented Oct 21, 2017

What is that other extension you have installed? I test with only uBO, no other extension.

@bup4gr
Copy link
Author

bup4gr commented Oct 21, 2017

The problem is with noscript (extension installed by default with tor browser).

3 cases:

1.
- Security level in Tor Browser is high or medium
- disable all plugins (except tor button and torlauncher)
- close and reopen tor browser
- enable ublock
- ublock works (the only plugin enabled)

2.
- Security level in Tor Browser is high or medium
- disable all plugins (except tor button and torlauncher)
- close and reopen tor browser
- enable ublock
- close and reopen tor browser
- enable noscript
- ublock works (also if noscript is enable and also if close and reopen tor browser)

3.
- Security level in Tor Browser is high or medium
- disable all plugins (except tor button and torlauncher)
- close and reopen tor browser
- enable noscript
- close and reopen tor browser
- enable (or install) ublock
- ublock DON'T works

From my own experience:
The third case is the most common because noscript is enabled in the tor browser installation.
When security level in Tor browser is changed to medium or high, are also changed some settings in noscript (for example is disabled javascript).
This changes cause the problem in ublock.
So if Tor browser has security level medium or high, and noscript is enabled before ublock, then ublock don't work.
All people that install tor browser and then install ublock have this problem, if the security level is medium or high (also if security level is changed to medium or high after installation of ublock).

Are you able to reproduce this problem?
Is there a solution to solve this problem?

@bup4gr
Copy link
Author

bup4gr commented Oct 22, 2017

After some test in "case 2", i see that in ublock the filters work, but "element picker" and "element zapper" don't work

@gorhill
Copy link
Owner

gorhill commented Oct 22, 2017

@laniakea64 Any known issue with NoScript to explain observations in #3156 (comment)?

@laniakea64
Copy link

I'm not the best person to ask. I don't know Tor browser at all.

Is this reproducible in the corresponding Firefox version?

@Hrxn
Copy link

Hrxn commented Oct 22, 2017

Should be, Tor Browser is basically Firefox, after all. Maybe some different default settings..

@gorhill
Copy link
Owner

gorhill commented Oct 22, 2017

I am not able to reproduce case 2 or 3. uBO works fine in either case.

@bup4gr
Copy link
Author

bup4gr commented Oct 28, 2017

Today i made other tests (torbrowser 7.0.8 and ublock 1.14.16) and ublock don't works also if is the only extension enabled (with torbutton and torlauncher)
im

Then i disable ublock, reactive it and then ublock works.
im2

So, after more tests, i think that the problem is not related with noscript, but i don't understand the source of the problem.

@gorhill
Copy link
Owner

gorhill commented Oct 28, 2017

As said above, I can't reproduce your issue with uBO and Tor Browser in medium security mode, with or without NoScript. So at this point this means whoever is able to reproduce it will have to investigate on their side to narrow the cause of it.

cqx931 pushed a commit to cqx931/AdNauseam that referenced this issue Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants