Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Ublock Origin's URL logger behaviour #391

Closed
enomat opened this issue Jun 22, 2015 · 7 comments
Closed

Problem with Ublock Origin's URL logger behaviour #391

enomat opened this issue Jun 22, 2015 · 7 comments

Comments

@enomat
Copy link

enomat commented Jun 22, 2015

The logger doesn't show the media files.

  1. Open this page:

www.europa2.sk/srv/www/content/db/sk/tim-a-show/mp3-archiv/

  1. Type this in the logger's filter:

.mp3

If you open Adbock's blockable item list, you can find this url. Adbolck Plus/Edge recognizes it as "audio/video" type.

http://i.lagardere.cz/europa2/file/edee/tim-a-show/mp3-archiv/15388/06_0.mp3

The Ublock Origin's behaviour is strange and buggy.

  • Sometimes this URL doesn't appear in Ublock Origin's logger.
  • Sometimes multiple instances will appear of the same file.
  • Sometimes only one URL will appear.

I've even created a new clean Firefox profile, installed Ublock Origin 0.9.9.1 from addons.mozilla.org .

Screenshot:
ublockbug_3

Then opened the above mentioned page (www.europa2.sk/srv/www/content/db/sk/tim-a-show/mp3-archiv/), and:

  • reloaded that page multiple times
  • disabled/enabled Ublock Origin, then tried again the refreshing

The bug occurs randomly.

Tried the standard µBlock 0.9.3.5 from addons.mozilla.org, but the problem is the same.

This bug means that the Ublock's logger engine is not reliable.

@gorhill
Copy link
Owner

gorhill commented Jun 22, 2015

uBlock reports exactly whatever Firefox API passes to uBlock.

I can see this resource is pulled differently by Firefox, using ranges:

Range: bytes=0-

And thus the response from the remote server looks like:

206 Partial Content 
Content-Range: bytes 0-115826687/115826688

Notice, 206, not 200.

If there are multiple entries for the same resource, it's simply because Firefox's makes multiple requests for the same resource, uBlock merely shows you what is happening internally, it does not create entries out of thin air.

@enomat
Copy link
Author

enomat commented Jun 22, 2015

But even if the URL is not shown in the logger, the media file still downloads and plays. (So the user won't be able to find the URL of the media file that is playing, if the bug occured while he is using the logger.)

The problem is still that Ublock sometimes doesn't report all the files that are downloaded from the page.

And it's worth mentioning that Adblock Plus/Edge shows this file every time properly (always one .mp3 URL at every refresh).

@gorhill
Copy link
Owner

gorhill commented Jun 22, 2015

problem is still that Ublock sometimes doesn't report all the files that are downloaded from the page

This could be because the HTTP observer is not taking into account cached resources. This can be added.

@neilishere
Copy link

I also have problems with the unified logger:
When the selector is set "behind-the-scene" and I "reload all tabs", the logger becomes flooded with all requests (as if the selector changes to "all"), but the selector still says "behind-the-scene". Then if I hit the eraser, only behind-the-scene requests are deleted. It is not only until I change the selector to "all" and hit eraser, and select "behind-the-scene" again can I resume monitoring.

Opera 30 and Palemoon 25 (both stable) on win 8.1 - ublock 9.9.2

Some history: My other computer has same Opera but with ublock 9.6.0 (last version before unified logger), and behind-the-scene logger is "pinned", and only behind-the-scene requests are shown - even after launch. (Sure, some requests are not blocked or missing after launch, but I just hit eraser and can resume monitoring behind-the-scene requests)

Thank you

@gorhill
Copy link
Owner

gorhill commented Jun 25, 2015

@neilishere Please open a new issue, merging all kind of different issues into a single one is messy.

@enomat
Copy link
Author

enomat commented Jun 28, 2015

But that .mp3 file is never cached. (It always starts downloading from the beginning.)

If you disable/enable Ublock Origin in the current session, there will be higher chance for the problem to occur.

Tried the latest version (0.9.9.3-dev.0) but the bug is still there.

@gorhill
Copy link
Owner

gorhill commented Jun 28, 2015

But that .mp3 file is never cached

I am tracing into the code and I can see only one network request reported by Firefox. Yet I am seeing 3 reported requests in the logger. Investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants