Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading mahakala.is host file. #724

Closed
Zegnat opened this issue Sep 19, 2015 · 4 comments
Closed

Loading mahakala.is host file. #724

Zegnat opened this issue Sep 19, 2015 · 4 comments

Comments

@Zegnat
Copy link

Zegnat commented Sep 19, 2015

I tried to load in the host files used by Pi-Hole, this includes adblock.mahakala.is. After a long time loading uBlock₀ just reports it as “0 used out of 0” and “out of date”. Would there be any way to load this (frankly, huge) hosts list into uBlock Origin?

@ghost
Copy link

ghost commented Sep 20, 2015

$ wget adblock.mahakala.is -U Mozilla
--2015-09-19 19:27:53--  http://adblock.mahakala.is/
Resolving adblock.mahakala.is (adblock.mahakala.is)... 93.95.225.235
Connecting to adblock.mahakala.is (adblock.mahakala.is)|93.95.225.235|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 47453390 (45M) [application/octet-stream]
Saving to: ‘index.html’

index.html                                       100%[=========================================================================================================>]  45.25M   372KB/s   in 76s    

2015-09-19 19:29:09 (609 KB/s) - ‘index.html’ saved [47453390/47453390]

https://github.com/gorhill/uBlock/blob/master/src/js/assets.js#L285-L330
xhr.timeout = 30000, which is 30000 ms, or 30s
It takes longer than 30s to download the entire file, unless you have a fast internet connection.

@Zegnat
Copy link
Author

Zegnat commented Sep 20, 2015

Cheers, now I know! Didn’t think to check for a build in time-out, that’s on me.

For whatever reason it seems that uBlock (for Firefox) doesn’t report on this happening though. It happily put a checked the box in front of the entry and displayed “0 used out of 0” rather than the expected “out of ?” for unloaded lists. Possible bug (or lack of implementation) on the error reporting to the user there?

@gorhill
Copy link
Owner

gorhill commented Sep 20, 2015

It's reported in the extension console (Chromium) or browser console (Firefox). There is an open issue somewhere for uBlock related to this, the error needs to propagate to the user. In any case, having uMatrix/uBlock download huge file is discouraged. Somewhere in the wiki I advise to download through other mean locally, and supply uMatrix/uBlock a URL to that local location. Firefox accepts file:// URL last time I checked. Otherwise a local HTTP server for just this purpose should work fine.

What I could do is to have a local config setting to tamper with the timeout value, so that users could set their own value. Not something I would expose through the UI though, that would be too risky to have novice users play with this, could easily break uMatrix/uBlock.

@Zegnat
Copy link
Author

Zegnat commented Sep 20, 2015

It's reported in the extension console (Chromium) or browser console (Firefox). There is an open issue somewhere for uBlock related to this, the error needs to propagate to the user.

If there already is an issue, then we’ll close this.

Somewhere in the wiki I advise to download through other mean locally, and supply uMatrix/uBlock a URL to that local location.

Yep, it is here, and I have no idea how I missed it.

My apologies for the oversight.

@Zegnat Zegnat closed this as completed Sep 20, 2015
gorhill added a commit that referenced this issue Sep 25, 2015
gorhill added a commit to gorhill/uMatrix that referenced this issue Sep 26, 2015
Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants