Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce bare-fabric example #1099

Closed
wants to merge 1 commit into from

Conversation

AndreiCalazans
Copy link
Contributor

@AndreiCalazans AndreiCalazans commented Sep 13, 2022

Motivation

This includes a fabric enabled example that can be used to verify the library is properly working with Fabric.

The example app doesn't fully work with Fabric due to:

  1. The usage of findNodeHandle
  2. react-navigation's Card component using setNativeProps
  3. Reanimated's V3 RC crashing when using useReanimatedRef.

I have a follow up PR where I remove findNodeHandle usage from this library to make it fully compatible with Fabric.

cc @gorhom

@gorhom
Copy link
Owner

gorhom commented Sep 17, 2022

Thanks @AndreiCalazans for submitting this PR.

I don't think we need to have an example for Fabric, or at least a separate example. I will look into extracting the example into another repo in the feature.

@AndreiCalazans
Copy link
Contributor Author

Thanks @AndreiCalazans for submitting this PR.

I don't think we need to have an example for Fabric, or at least a separate example. I will look into extracting the example into another repo in the feature.

Sounds good. It made it easier for me to test both in parallel. The example apps are nicely setup, nice job by the way.

@only1chi
Copy link

only1chi commented Oct 3, 2022

Is there any plan to review and merge this PR?
I think this PR gets bottom-sheet compliant with reanimated v3.

@tomekzaw
Copy link

tomekzaw commented Oct 3, 2022

Reanimated's V3 RC crashing when using useReanimatedRef.

Hello! Could you please submit an issue in Reanimated repo so we can address this problem as soon as possible? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants