Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace findNodeHandle for getRefNativeTag #1100

Merged
merged 1 commit into from Sep 17, 2022

Conversation

AndreiCalazans
Copy link
Contributor

@AndreiCalazans AndreiCalazans commented Sep 13, 2022

Motivation

Make this library compliant with the new Fabric architecture. Follow up to the Fabric enabled example app.

Gif of it working with old architecture:

bottom-sheet-scrollable-demo

Gif of it working with Fabric: (note example app is slightly broken due to dependencies not being fully compatible yet)

android_ios_demo_bottom_sheet

cc @gorhom

@gorhom gorhom added the v4 Written in Reanimated v2 label Sep 16, 2022
@gorhom gorhom self-assigned this Sep 16, 2022
Copy link
Owner

@gorhom gorhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @AndreiCalazans for submitting this PR

@gorhom gorhom merged commit 1a8928f into gorhom:master Sep 17, 2022
@AndreiCalazans AndreiCalazans deleted the fabric-compatible branch September 19, 2022 11:29
@capezzbr capezzbr mentioned this pull request Sep 19, 2022
@smontlouis
Copy link

It's broken on expo-web

Uncaught Error: Unexpected nativeTag: function; nativeTag=[object HTMLDivElement] 

			createBottomSheetScrollableComponent's ScrollableComponent needs to return 
			a reference that contains a nativeTag to a Native HostComponent.

ref=function _f(component) {
        if (component) {
          tag.value = Object(_NativeMethods__WEBPACK_IMPORTED_MODULE_1__["getTag"])(component);
          fun.current = component;
        }

        return tag.value;
      }

@giaset
Copy link

giaset commented Oct 17, 2022

Having the same issue as @smontlouis on web

joemun added a commit to discord/react-native-bottom-sheet that referenced this pull request Aug 29, 2023
Revert "refactor: replace findNodeHandle for getRefNativeTag" gorhom#1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants