Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function instead of component for BottomSheetModal children #1750

Merged
merged 1 commit into from
May 19, 2024

Conversation

Kerumen
Copy link

@Kerumen Kerumen commented Feb 22, 2024

Motivation

As data is an object, rendering <Content data={data} /> creates a lot of unwanted re-render. Changing it to a function solves this issue.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@Kerumen
Copy link
Author

Kerumen commented Mar 24, 2024

@gorhom Can you have a look? Thanks 🙏🏻

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@Kerumen
Copy link
Author

Kerumen commented Apr 25, 2024

Quick comment to remove the stale label..

@gorhom gorhom self-assigned this May 19, 2024
@gorhom gorhom merged commit 6cfc99f into gorhom:master May 19, 2024
@Kerumen Kerumen deleted the patch-1 branch May 20, 2024 07:26
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants