Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added handleOnContentSizeChange for scrollables #301

Merged
merged 1 commit into from
Feb 20, 2021
Merged

chore: added handleOnContentSizeChange for scrollables #301

merged 1 commit into from
Feb 20, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Feb 19, 2021

Closes #286

Motivation

this pr added handleOnContentSizeChange to scrollables, to reset scrollableContentOffsetY when the content size of the scrollable become smaller.

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/reset-scrollable-offset-when-size-change

@gorhom gorhom added the v2 Written in Reanimated v1 label Feb 19, 2021
@gorhom
Copy link
Owner Author

gorhom commented Feb 19, 2021

@saransh-malik could you test this pr :)

@saransh-malik
Copy link

@gorhom Yes, perfectly fixes the issue. Thank you so much :)

@gorhom gorhom merged commit bf7a255 into master Feb 20, 2021
@gorhom gorhom deleted the fix/reset-scrollable-offset-when-size-change branch February 20, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2 Written in Reanimated v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List freeze on dynamic items [v2]
2 participants
@gorhom @saransh-malik