Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modrinth mod/modpack support #1391

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Pyroglyph
Copy link

@Pyroglyph Pyroglyph commented Jul 4, 2022

(This picks up where #1352 left off after the big history clean)

Purpose

Currently, GDLauncher does not support downloading mods/modpacks hosted on the Modrinth platform. This feature has been requested in issue #768.

I'm aware of GDevs' other project ferium which already supports Modrinth, and also the gdlib-refactor branch (which I assume may eventually succeed GDLauncher?), but that branch is far from completion.

Approach

This PR allows users to search for and install mods and modpacks hosted on Modrinth in the same way that they can currently be installed from CurseForge and FTB.

image

The implementation is highly based on the existing CurseForge/FTB installer code so it adds no new dependencies, which I see as an advantage.

Open Questions and Pre-Merge TODOs

  • Add support for searching for and installing modpacks from Modrinth
  • Add support for searching for and installing individual mods from Modrinth
  • Add a proper way to show errors to the user (i.e. when a mod fails to download, or when the user tried to install an unsupported pack type like Quilt)
  • Modrinth provides fallback download links for overrides. If an override file fails to download, the launcher should retry the download using given alternate links.
  • Waiting on Add Quilt Support #1400 so we can take immediate advantage of Modrinth's Quilt packs

Learning

I have read the Modrinth API docs (linked below).

Resources

Squashed from Pyroglyph/GDLauncher/tree/modrinth-support
@Eskaan Eskaan added the Type: Feature Requests to add a feature to the app label Jul 5, 2022
@AshtakaOOf
Copy link

Modrinth said on Twitter that api user should have a User-Agent.
Here the documentation: https://docs.modrinth.com/api-spec/#section/User-Agents

@AshtakaOOf
Copy link

I found some issues with the build #1746 can you tell me if you fixed them or not?
Here are the issues:

  1. Mods manager doesn't automatically detect the modloader to download mods
  2. Mods manager doesn't automatically detect which version of minecraft you are on
    I hope you can fix these issues, even if you said you were waiting for the other pull request to be done.

@Pyroglyph
Copy link
Author

@AshtakaOOf
While trying to check for those issues I found a few more, so it seems I still have more work to do on this.

@Hedwig7s
Copy link

I would definetly recommend getting it working as soon as possible as more and more mods are moving to Modrinth

@Hedwig7s
Copy link

Would recommend just adding a pull request after this to add QuiltMC support to the patch because there's been no activity on that pull request and alot of big mods are moving and it's starting to really get annoying

@Ecorous
Copy link

Ecorous commented Aug 4, 2022

Would recommend just adding a pull request after this to add QuiltMC support to the patch because there's been no activity on that pull request and alot of big mods are moving and it's starting to really get annoying

Me and Pyro had already talked about this before I started the PR :P

@Pyroglyph
Copy link
Author

Pyroglyph commented Sep 7, 2022

I've come back after a few weeks off this project and suddenly it wasn't working. I did some investigation and found that when I merged this commit caused a total freeze (but not a crash) when opening the Manage window of an instance. It happens on both Windows and Linux on 2 different machines, so it's not isolated. I haven't figured out why yet.

I've rewritten the history of my branch to remove the times I merged from the master branch and that has stopped the issue, hence the recent force push.

Edit: The commit I mentioned earlier is the problem. Merging the latest master in breaks it, reverting that commit fixes it.

@Eskaan Eskaan linked an issue Sep 9, 2022 that may be closed by this pull request
@mecwerks
Copy link

Hello! I was wondering if you had any leads as to what the issue is? I wanted to take a crack at it and I'm curious if there was any work already put into resolving it.

@lpuv
Copy link

lpuv commented Dec 15, 2022

Hi! Any progress on this?

@quartzar
Copy link

Status...?

Iris has just been removed from CurseForge... now would be THE time to get on with this.

@Hedwig7s
Copy link

Please stop waiting on the Quilt pull. Nothing is happening with it

@ToyB-Chan
Copy link

Are we still waiting for the Qulit support?

@blarfoon
Copy link
Member

blarfoon commented Jul 1, 2023

Quilt has been added already to the rewrite. We will release it in open beta by end of August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Requests to add a feature to the app
Development

Successfully merging this pull request may close these issues.

support modrinth
10 participants