Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand libium's heuristic for github to use release name if only one jar is associated with the release #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garethgeorge
Copy link

Untested implementation that expands libium's heuristic for github releases to capture the common pattern of mod version in the release name with a single associated jar. For an example see Cow's odd widgets.

The heuristic implemented is:

  • If there are multiple .jar assets, check for a version in the asset name.
  • If there is a single .jar asset, check version in the asset name and fallback to the release name.

This code compiles, but I'm looking for guidance on testing pattern for libium as I'm not seeing tests in the repository and ran into some issues when trying to build ferium with a local copy.

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants