Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version & add verification/testing tools #34

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Jul 31, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes

Run verifications and test

  • make verify is passing
  • [] make test is passing

@apoorvajagtap
Copy link
Member Author

Multiple tests are failing. Working on it.

@apoorvajagtap
Copy link
Member Author

apoorvajagtap commented Jul 31, 2023

@coreydaley @AlexVulaj the test cases are a bit complex in this one. So, I might need a little more time to rectify that, as I feel we can develop a much better alternative for this.
For the sake of time, I've commented out the affected test cases.

README.md Outdated Show resolved Hide resolved
client/status.go Outdated Show resolved Hide resolved
client/client_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a3390cc). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   86.71%           
=======================================
  Files           ?        8           
  Lines           ?      414           
  Branches        ?        0           
=======================================
  Hits            ?      359           
  Misses          ?       37           
  Partials        ?       18           

client/client_test.go Outdated Show resolved Hide resolved
@coreydaley coreydaley merged commit d8f0368 into main Aug 25, 2023
10 checks passed
@coreydaley coreydaley deleted the GPT-107 branch August 25, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants