Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrader.Upgrade: use http.ResposnseController #871

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Upgrader.Upgrade: use http.ResposnseController #871

merged 2 commits into from
Jan 22, 2024

Conversation

ninedraft
Copy link
Contributor

@ninedraft ninedraft commented Nov 22, 2023 •
edited
Loading

Since go1.20 http.ResponseController is a preferable tool for connection hijacking. It allows to use custom response writer interceptors with Unwrap() http.ResponseWriter method.

@ninedraft ninedraft changed the title use http.ResposnseController Upgrader.Upgrade: use http.ResposnseController Nov 22, 2023
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 13, 2023
AlexVulaj
AlexVulaj approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@AlexVulaj AlexVulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Approved.

@AlexVulaj AlexVulaj merged commit 0f0acef into gorilla:main Jan 22, 2024
9 of 10 checks passed
@tebuka tebuka mentioned this pull request Jun 12, 2024
Closed
28 tasks
This was referenced Jun 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVulaj AlexVulaj AlexVulaj approved these changes

Assignees
No one assigned
Labels
size/S
Projects
Gorilla Web Toolkit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ninedraft @AlexVulaj