You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To release memory used by the net/http server, the upgrade handler should start new goroutines for read and write and then return the http handler function. Update all examples to follow this best practice.
Skip. Because this package does not define the default buffer sizes on the server, there's no guarantee that the comment is accurate. If an application programmer does care about the size, then they should specify a size instead of relying on a default.
Start from the commit before new maintainers took over the Gorilla WebSocket package in 2023. Pick or discard commits made since that time as follows:
80393295
Correct way to save memory using write buffer pool and freeing net.http default buffers gorilla/websocket#761
To release memory used by the net/http server, the upgrade handler should start new goroutines for read and write and then return the http handler function. Update all examples to follow this best practice.
Issue added: Update examples to return from http handler function after upgrade #17
666c197f (the 666 commit)
Update go version & add verification/testing tools gorilla/websocket#840
update GitHub workflows gorilla/websocket#857
Add Makefile and CI linters. Most other changes in the 666 commit are harmful.
78c34874
Skip
ac0789be
Skip
aa976062
Fixes subprotocol selection (aling with rfc6455) gorilla/websocket#823
Fixed in Fix subprotocol selection #10.
b6a0d77c
Update README.md, replace master to main gorilla/websocket#862
Fixed in Bring Tebuka up-to-date with Gorilla #1.
629990da
Use status code constant gorilla/websocket#864
Fixed in Misc cleanup #11.
6f5d2139
Skip. Fixes bug in the 666 commit.
286c8961
fix: replace ioutil.readfile with os.readfile gorilla/websocket#868
Fixed in Fix lint errors #7.
01b0aaed
Skip. Because this package does not define the default buffer sizes on the server, there's no guarantee that the comment is accurate. If an application programmer does care about the size, then they should specify a size instead of relying on a default.
dcea2f08
Skip. Fixes bug introduced in the 666 commit.
871f6bbc
docs(echoreadall): fix function echoReadAll comment gorilla/websocket#881
Fixed in Fix lint errors #7.
4a5e66f7
Skip. The change does not significantly decrease the time to run the test.
1e975a03, 0f0acefe
Upgrader.Upgrade: use http.ResposnseController gorilla/websocket#871
Fixed in Use http.ResponseController #16.
9a214051
Skip. Fixes bug introduced in the 666 commit.
49650807
Skip. Fixes bug introduced in the 666 commit.
7d5b8cce
Skip. Do not write to application's stderr.
cf50a3ef
Skip. Reverts previous commit.
d15aba1e, d08ee1ad
perf: reduce timer in write_control gorilla/websocket#879
Fixed in Improve WriteControl timeout #13.
31686144
fix: lint example code gorilla/websocket#890
Fixed in fix: lint example #12.
0cfb2caf, d293aa53
feat: format message type gorilla/websocket#889
Include fix for [BUG] FormatMessageType returns empty string for unknown type gorilla/websocket#910.
Fixed in Add FormatMessageType #15.
695e9095
Skip. Fixes bug introduced in the 666 commit.
b2a86a17
Do not timeout when WriteControl deadline is zero gorilla/websocket#898
Fixed in Improve WriteControl timeout #13.
58af1503
Skip. Fixes bug introduced in the 666 commit.
09a6bab4
Skip. Fixes bug introduced in the 666 commit.
b2c246b2, 1bddf2e0
Skip. This is an incomplete attempt to revert the 666 commit.
5fc9a591
Return 426 status on missing upgrade header gorilla/websocket#921
Fixed in Return 426 status on missing upgrade header #14.
eb8de5f0
Add test for computeAcceptKey gorilla/websocket#851
Fixed in Improve WriteControl timeout #13.
The text was updated successfully, but these errors were encountered: