-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reduce timer in write_control #879
perf: reduce timer in write_control #879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update!
5346582
to
65e092b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 71.21% 71.26% +0.05%
==========================================
Files 11 11
Lines 1584 1587 +3
==========================================
+ Hits 1128 1131 +3
Misses 349 349
Partials 107 107 ☔ View full report in Codecov by Sentry. |
@rfyiamcool Before merging - would you mind adding/updating tests for this change? |
65e092b
to
fb2b82c
Compare
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
fb2b82c
to
82e2b1a
Compare
done, the ut is ok ? 😁 |
What type of PR is this? (check all applicable)
Description
In most cases, we do not write concurrently to the same client, and the
gorilla
library limits the concurrency, whengorilla
detect write data concurrently, throw panic ? In the addition, creating and stopping a timer is not a simple action. 😁So, we can get the lock first and if we can't get it, we can create a timer. 😁
Run verifications and test
make verify
is passingmake test
is passing