Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to HiGlass 1.12.2 #866

Merged
merged 5 commits into from
Apr 19, 2023
Merged

feat: upgrade to HiGlass 1.12.2 #866

merged 5 commits into from
Apr 19, 2023

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Apr 6, 2023

Toward gosling-lang/gos#122

Change List

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi marked this pull request as draft April 6, 2023 16:34
@sehilyi sehilyi changed the title chore: working on using latest d3 APIs feat: upgrade to HiGlass 1.12.2 Apr 12, 2023
@sehilyi sehilyi marked this pull request as ready for review April 17, 2023 01:12
@sehilyi sehilyi requested a review from manzt April 17, 2023 01:18
Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a minor comment.

@manzt
Copy link
Member

manzt commented Apr 18, 2023

Do you think we will be able to make a release soon so we can also upgrade gos?

@sehilyi
Copy link
Member Author

sehilyi commented Apr 18, 2023

I received a report that there is an error with Buffer when using bigwig files (#876). I think we can release a version once we address it.

@sehilyi sehilyi merged commit 0bc5691 into master Apr 19, 2023
@sehilyi sehilyi deleted the sehilyi/higlass-12 branch April 19, 2023 20:13
sehilyi added a commit that referenced this pull request Apr 19, 2023
* chore: working on using latest d3 APIs

* chore: more dependencies

* chore: resolve startEvent type

* chore: add type to editor

* chore: use explicit type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants