Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(css3): replace TokenKind with utils & rust traits #235

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

neuodev
Copy link
Collaborator

@neuodev neuodev commented Nov 6, 2023

No description provided.

@neuodev neuodev requested a review from a team November 6, 2023 12:22
@neuodev neuodev changed the title refactor(css3): replace TokenKind with utils & rust traits refactor(css3): replace TokenKind with utils & rust traits Nov 6, 2023
Copy link
Collaborator

@emwalker emwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Vaguely curious whether this changes the performance in a measurable way, but I don't know if we have anything set up to measure this.

@neuodev neuodev merged commit 00ab68e into main Nov 6, 2023
4 checks passed
@neuodev neuodev deleted the ahmed/tokenizer-utils branch November 6, 2023 14:57
@neuodev
Copy link
Collaborator Author

neuodev commented Nov 6, 2023

LGTM.

Vaguely curious whether this changes the performance in a measurable way, but I don't know if we have anything set up to measure this.

It still pretty early to judge by performance at this stage. The final version of the code can be completely different.

@neuodev neuodev self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants