Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateField localization does not work in ajax setting #115

Closed
ghost opened this issue Dec 29, 2011 · 10 comments
Closed

DateField localization does not work in ajax setting #115

ghost opened this issue Dec 29, 2011 · 10 comments

Comments

@ghost
Copy link

ghost commented Dec 29, 2011

Hi,

DateField localization is broken if:

  1. The original page load (the non-ajax one) does not have any datefields (The localized js is never loaded)
  2. The date field is loaded using ajax (For us it is inside dialog)

Firebug shows that the correct localized .js file is downloaded to the browser, but I suspect that the contents is not ever evaluated.

If you take a look at the localized source code it is essentially:

jQuery(function($){
$.datepicker.regional['fi'] = {
closeText: 'Sulje',
... .... .... ... ... ...
$.datepicker.setDefaults($.datepicker.regional['fi']);
});

Is it so that the file is never evaluated when loaded using ajax?

  • Ville
@EmmanuelDemey
Copy link
Contributor

Hi

I have just make a test with a zone, not visible by default, with a datefield, and when I update the zone, I have got the right language ! I tested for french and english.

Can you send to me a sample (template and java), in order to get the error. Thanks a lot

Manu

@EmmanuelDemey
Copy link
Contributor

Before, Can you test with the last SNAPSHOT version ?

@EmmanuelDemey
Copy link
Contributor

I have just created an Integration Test. If it is not enough for your issue, can you provide an java class and a template for your page, and also a test ? thanks

@ghost
Copy link
Author

ghost commented Feb 3, 2012

Hi,

I just created a pull request that fixes the integration test for #115. If you need any more help to reproduce just let me know. (Pull request is #131)

  • Ville

@EmmanuelDemey
Copy link
Contributor

Hi

Can you test my patch ?

Manu

@ghost
Copy link
Author

ghost commented Feb 10, 2012

I'm a bit busy right now, it will take a week or two before I can get back to this. Does it fix the integration test? (If you navigate to it manually and run it that way?)

@EmmanuelDemey
Copy link
Contributor

It fix the Integration test !

@EmmanuelDemey
Copy link
Contributor

Some news about this issue ?

@ghost
Copy link
Author

ghost commented Apr 16, 2012

Hi!

I've been assigned to other tasks, currently https://github.com/eloukkola is assigned to this task. Esa, could you take care of this matter, thank you!

@eloukkola
Copy link

Hi, finally had some time to look into this and I can confirm that this works in 3.2.0, so this issue can be closed.

Esa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants