DateField localization does not work in ajax setting #115

Closed
villeapvirtanen opened this Issue Dec 29, 2011 · 10 comments

Comments

Projects
None yet
3 participants
@villeapvirtanen
Contributor

villeapvirtanen commented Dec 29, 2011

Hi,

DateField localization is broken if:

  1. The original page load (the non-ajax one) does not have any datefields (The localized js is never loaded)
  2. The date field is loaded using ajax (For us it is inside dialog)

Firebug shows that the correct localized .js file is downloaded to the browser, but I suspect that the contents is not ever evaluated.

If you take a look at the localized source code it is essentially:

jQuery(function($){
$.datepicker.regional['fi'] = {
closeText: 'Sulje',
... .... .... ... ... ...
$.datepicker.setDefaults($.datepicker.regional['fi']);
});

Is it so that the file is never evaluated when loaded using ajax?

  • Ville
@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Feb 3, 2012

Contributor

Hi

I have just make a test with a zone, not visible by default, with a datefield, and when I update the zone, I have got the right language ! I tested for french and english.

Can you send to me a sample (template and java), in order to get the error. Thanks a lot

Manu

Contributor

Gillespie59 commented Feb 3, 2012

Hi

I have just make a test with a zone, not visible by default, with a datefield, and when I update the zone, I have got the right language ! I tested for french and english.

Can you send to me a sample (template and java), in order to get the error. Thanks a lot

Manu

@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Feb 3, 2012

Contributor

Before, Can you test with the last SNAPSHOT version ?

Contributor

Gillespie59 commented Feb 3, 2012

Before, Can you test with the last SNAPSHOT version ?

@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Feb 3, 2012

Contributor

I have just created an Integration Test. If it is not enough for your issue, can you provide an java class and a template for your page, and also a test ? thanks

Contributor

Gillespie59 commented Feb 3, 2012

I have just created an Integration Test. If it is not enough for your issue, can you provide an java class and a template for your page, and also a test ? thanks

@villeapvirtanen

This comment has been minimized.

Show comment
Hide comment
@villeapvirtanen

villeapvirtanen Feb 3, 2012

Contributor

Hi,

I just created a pull request that fixes the integration test for #115. If you need any more help to reproduce just let me know. (Pull request is #131)

  • Ville
Contributor

villeapvirtanen commented Feb 3, 2012

Hi,

I just created a pull request that fixes the integration test for #115. If you need any more help to reproduce just let me know. (Pull request is #131)

  • Ville
@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Feb 8, 2012

Contributor

Hi

Can you test my patch ?

Manu

Contributor

Gillespie59 commented Feb 8, 2012

Hi

Can you test my patch ?

Manu

@villeapvirtanen

This comment has been minimized.

Show comment
Hide comment
@villeapvirtanen

villeapvirtanen Feb 10, 2012

Contributor

I'm a bit busy right now, it will take a week or two before I can get back to this. Does it fix the integration test? (If you navigate to it manually and run it that way?)

Contributor

villeapvirtanen commented Feb 10, 2012

I'm a bit busy right now, it will take a week or two before I can get back to this. Does it fix the integration test? (If you navigate to it manually and run it that way?)

@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Feb 10, 2012

Contributor

It fix the Integration test !

Contributor

Gillespie59 commented Feb 10, 2012

It fix the Integration test !

@Gillespie59

This comment has been minimized.

Show comment
Hide comment
@Gillespie59

Gillespie59 Apr 16, 2012

Contributor

Some news about this issue ?

Contributor

Gillespie59 commented Apr 16, 2012

Some news about this issue ?

@villeapvirtanen

This comment has been minimized.

Show comment
Hide comment
@villeapvirtanen

villeapvirtanen Apr 16, 2012

Contributor

Hi!

I've been assigned to other tasks, currently https://github.com/eloukkola is assigned to this task. Esa, could you take care of this matter, thank you!

Contributor

villeapvirtanen commented Apr 16, 2012

Hi!

I've been assigned to other tasks, currently https://github.com/eloukkola is assigned to this task. Esa, could you take care of this matter, thank you!

@eloukkola

This comment has been minimized.

Show comment
Hide comment
@eloukkola

eloukkola May 3, 2012

Hi, finally had some time to look into this and I can confirm that this works in 3.2.0, so this issue can be closed.

Esa

Hi, finally had some time to look into this and I can confirm that this works in 3.2.0, so this issue can be closed.

Esa

@Gillespie59 Gillespie59 closed this May 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment