Skip to content
This repository

-color settings ignored whitin ipdb #1

Closed
brickZA opened this Issue February 22, 2011 · 4 comments

2 participants

Neilen Marais Godefroid Chapelle
Neilen Marais

I originally reported this issue as an ipython bug, but it looks like may be possible to fix it by making changes to ipdb. See ipython/ipython#279

Godefroid Chapelle
Owner

I'll take care of this asap.

Godefroid Chapelle
Owner
gotcha commented June 11, 2011

In ipython/ipython#279, you state :

OK. So if I do ipape.get().options.colors in a straight ipython shell, it gives the right answers. Then I instrumented ipdb to print the
same info, and it always gave Linux. Then I saw the following lines in ipdb/init.py:

from IPython.Shell import IPShell
...
shell = IPShell(argv=[''])

By commenting out the the last line, the correct info is obtained by ipdb. Presumably a new ipython shell with default options is
created by the IPShell() statement. Why would ipdb do this? A quick smoke test seems to indicate that ipdb works OK without it.

P.S. the ipdb file I have matches this one:
https://github.com/gotcha/ipdb/blob/master/ipdb/__init__.py

Godefroid Chapelle
Owner
gotcha commented June 11, 2011

As soon as I commented the line you mention,

I got

Traceback (most recent call last):
  File "manual_test.py", line 11, in <module>
    main()
  File "manual_test.py", line 7, in main
    import ipdb; ipdb.set_trace()
  File "/Users/gotcha/tmp/ipdbrel/lib/python2.6/site-packages/ipdb/__init__.py", line 11, in set_trace
    def_colors = ip.options.colors
AttributeError: 'NoneType' object has no attribute 'options'

This made me think that I do not use ipdb the same way as you do.

I guess that you are actually using ipdb from inside IPython.

If this is correct, my last commit should fix the issue.

Can you confirm ?

Neilen Marais

Indeed, I run it from within IPython. It also seems to work correctly with your latest revision.

Godefroid Chapelle gotcha closed this issue from a commit June 13, 2011
Godefroid Chapelle fix changelog
closes #1
5644ea9
Godefroid Chapelle gotcha closed this in 5644ea9 June 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.