Removed lexical comparison for version numbers and replaced with pkg_resources #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources module, in order to use parse_version for comparisons
|
Thanks ! Can you add the dependency on |
|
Apologies, I forgot to add that in. The package required for pkg_resources is distributed with setuptools. Presumably this is OK? |
|
Right, you want to depend on |
|
My mistake, thanks. |
gotcha
added a commit
that referenced
this pull request
Jan 27, 2016
Removed lexical comparison for version numbers and replaced with pkg_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lexical comparison was causing incorrect behaviour. Fix implemented using pkg_resources.