Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proto): mitigate possible DOS in gzip decoding #42

Merged
merged 5 commits into from
Dec 19, 2020
Merged

feat(proto): mitigate possible DOS in gzip decoding #42

merged 5 commits into from
Dec 19, 2020

Conversation

ernado
Copy link
Member

@ernado ernado commented Dec 19, 2020

Limit gzip decompressed data reader with maximum of 10 mb.

@coveralls
Copy link

coveralls commented Dec 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 432752381

  • 18 of 32 (56.25%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 39.474%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/proto/codec/full.go 1 2 50.0%
bin/buffer.go 0 6 0.0%
internal/proto/gzip.go 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
internal/proto/gzip.go 2 61.54%
Totals Coverage Status
Change from base Build 432626403: 0.3%
Covered Lines: 2267
Relevant Lines: 5743
💛 - Coveralls

@ernado ernado merged commit 22334d9 into main Dec 19, 2020
@ernado ernado deleted the feature/proto-gzip-mitigate-oom branch December 19, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernado @coveralls