Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bookmarklets in toolbox to functions #20

Closed
gotdibbs opened this issue Jan 16, 2020 · 2 comments
Closed

Migrate bookmarklets in toolbox to functions #20

gotdibbs opened this issue Jan 16, 2020 · 2 comments

Comments

@gotdibbs
Copy link
Owner

Originally bookmarklets were included in the toolbox UI to reduce code, but as bookmarklets are being deprecated, a split out is warranted for better debugging. Bookmarklets have a finite function length so removing that limitation will help us make newer better experiences.

gotdibbs added a commit that referenced this issue Jan 20, 2020
Fixes #18, #20
- Converted bookmarklets to ES Modules for chrome extension
- Patched a bunch of issues that resulted from strict mode on modules
- Changed loading methodology to be less noisy
- Hide all utilities that don't work for v9
- Defensive coding for some honeybadger alerts including retry functionality (still can't tell what actual issue is where bookmarklets would fail to get form context, but hopefully this will help)
- Started splitting out launcher.js into modules
@Nafferty
Copy link

@gotdibbs Missing CRM dev? Glad to see there's still activity here. It's almost like you're not gone :(

@gotdibbs
Copy link
Owner Author

@Nafferty I wouldn't say I'm exactly missing it but I'm not not missing it. Just trying to keep all my friends (read: weekly users) in the Netherlands happy 😅

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants