Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to turn off logging for /ping ..? #74

Closed
compleatang opened this issue May 23, 2019 · 0 comments
Closed

Possible to turn off logging for /ping ..? #74

compleatang opened this issue May 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@compleatang
Copy link

Context: we run gotenburg in a kubernetes cluster as part of an overall deployment which includes other microservices that sit "in front" of gotenburg. Currently gotenburg is running fine, but when we go to pull logs they are almost completely unusable because every time we've healthcheck-ed it via a /ping that adds a log line to the output.

Obviously we can pull the logs and grep, but it is a bit annoying given that we have no need to understand that a ping happened cause we can pull that information from kubernetes events.

@gulien gulien added the enhancement New feature or request label May 23, 2019
gulien pushed a commit that referenced this issue Jun 3, 2019
Signed-off-by: Casey Kuhlman <casey@monax.io>
gulien pushed a commit that referenced this issue Jun 3, 2019
* skip logging when healthcheck url is called; closes #74

Signed-off-by: Casey Kuhlman <casey@monax.io>

* skip logging when healthcheck url is called; closes #74

Signed-off-by: Casey Kuhlman <casey@monax.io>

* adds the ability to establish the listen port via env var

Signed-off-by: Casey Kuhlman <casey@monax.io>
gulien added a commit that referenced this issue Jun 3, 2019
…ISTEN_PORT (#78)

* skip logging when healthcheck url is called; closes #74 (#75)

Signed-off-by: Casey Kuhlman <casey@monax.io>

* Configure listen port via environment variable (#77)

* skip logging when healthcheck url is called; closes #74

Signed-off-by: Casey Kuhlman <casey@monax.io>

* skip logging when healthcheck url is called; closes #74

Signed-off-by: Casey Kuhlman <casey@monax.io>

* adds the ability to establish the listen port via env var

Signed-off-by: Casey Kuhlman <casey@monax.io>

* minor refactoring of @compleatang work

* fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants