skip logging when healthcheck url is called #75
Conversation
|
Hello @compleatang, Thank you for this PR! I wonder if it should be enable/disable through an environment variable like |
|
@gulien should be all set now. |
|
Actually the environment variable should be retrieved in the main.go. See how I do it with |
|
Pending tests passing should be all set now. |
|
Not really sure what's happening with that test failure. I cannot see why the simple change would cause that test to fail and on my local machine I cannot recreate the failure. Unfortunately I do not have permissions to rerun it to see if there is a kink in the matrix. |
Signed-off-by: Casey Kuhlman <casey@monax.io>
|
FWIW, I pushed a commit that mirrors origin/master and the travis job failed at the same place -> https://travis-ci.org/compleatang/gotenberg/jobs/537723905 |
|
Sorry for the delay @compleatang. I'll try to take a look at your PR next week, I'm quite busy atm. |
|
No prob! |
…ISTEN_PORT (#78) * skip logging when healthcheck url is called; closes #74 (#75) Signed-off-by: Casey Kuhlman <casey@monax.io> * Configure listen port via environment variable (#77) * skip logging when healthcheck url is called; closes #74 Signed-off-by: Casey Kuhlman <casey@monax.io> * skip logging when healthcheck url is called; closes #74 Signed-off-by: Casey Kuhlman <casey@monax.io> * adds the ability to establish the listen port via env var Signed-off-by: Casey Kuhlman <casey@monax.io> * minor refactoring of @compleatang work * fixing typo
This PR closes #74.
I wasn't sure organizationally the best fit in terms of location for the skip function, so I added it into middleware.go with the other middleware functions.
I also took the opportunity to add the
/pingendpoint as a constant just to DRY it up a bit. Tested locally and it works as expected.