Fix audit vulnerabilities & e2e specs #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using npm audit fix
Verified that 'build' and 'unit' commands run todo: verify that e2e tests still run after installing Selenium prereqs note: seems likely that e2e tests will fail, given that they still refere to Vue h1 defaults
Discovered incompatible version while running 'e2e' todo: fix broken, original e2e tests, as originally noticed
Only replace initial 3, default Vue specs Door is now open to implement more comprehensive e2e suite
Confirmed 'build' and 'test' (unit & e2e) work correctly
Confirm 'dev', 'build', and 'test' (unit & e2e) all work correctly
Verify 'dev', 'build', and 'test' (unit & e2e) all still work correctly todo: examine vulnerabilities requiring manual fixes; all dependencies of favicons-webpack-plugin
chapitak
pushed a commit
to chapitak/vue-realworld-example-app
that referenced
this pull request
Nov 22, 2022
…ppa/jackkoppa-audit-fixes Fix audit vulnerabilities & e2e specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all critical, high, and moderate importance vulnerabilities reported by
npm audit. All major semver package updates were individually tested, runningdev,build, andtestafter each update. The 3 remaining vulnerabilities are low priority, from thefavicons-webpack-plugindev dependency (see open issue). Closes #51.During update of nightwatch to 1.0.10, recognized that the current e2e spec is copied from the default Vue.js app, and was thus failing. This PR removes the old specs, and adds 3 basic new specs, so that
npm run e2enow passes. Ideally, future work can be done on a more full e2e suite. Closes #52.