Replace Picasso with Coil

[cyb3rko]

Replaces the image loading library picasso with a well-maintained and modern alternative:
https://github.com/coil-kt/coil

@jmattheis
@IanQuilter

Please try it out :)
Do you need an APK?

[IanQuilter]

Replaces the image loading library picasso with a well-maintained and modern alternative: https://github.com/coil-kt/coil

@jmattheis @IanQuilter

Please try it out :) Do you need an APK?

Sorry for the delay in replying but I've been away and had problems trying to reply when viewing on a mobile.
I'm not a programmer and I cannot figure out how to use the coil code with the current Gotify Android app so if you are able to supply an apk I would appreciate it and I can test it.

Reading the posts since your original reply it appears that you are both still working on it and trying to sort out some issues. If you can get an apk working and want it testing I'm more than happy to test it out and provide feedback. Thanks for all your work trying to get it sorted.

[cyb3rko]

@IanQuilter
Hello there, I would suggest that I send you an apk as soon as we have figured out the details and implemented them.
Then you could test that on your system

[IanQuilter]

@cyb3rko
Thanks for the reply. As I said, unfortunately, as I'm not a programmer I can't help with the coding but I'm more than happy to test an apk once you have a, hopefully, working solution.
I'm just gratefull that both of you are trying to find a solution to what appears to be a problem that most users don't have!

[jmattheis]

Awesome, thanks!

[cyb3rko]

@IanQuilter Here's a development build of the new implementation.
Feel free to try it out:

https://cdn.cyb3rko.de/Apps/Gotify/Gotify%20Imageloading%20Dev.apk
MD5: b018ed9b26054d5dd46875e462f12c4a

[IanQuilter]

Thanks for all the time and effort you've put into this. I'll give the apk a try and let you know how it performs. Due to the way my Gotify alerts are generated it may take a week or more to confirm that it has cured the problem of using an incorrect cached image. But if any issues appear before then I'll let you know as soon as I find them.

Thanks.

@IanQuilter Here's a development build of the new implementation. Feel free to try it out:

https://cdn.cyb3rko.de/Apps/Gotify/Gotify%20Imageloading%20Dev.apk MD5: b018ed9b26054d5dd46875e462f12c4a

[IanQuilter]

Well that happened quicker than I thought it would!
I have the original and the dev version running on my phone and today the original served up an incorrect image from it's cache, while the dev version served up the correct image. This happened 3 or 4 times during the day which surprised me as it would often not happen for up to a week. But it does depend on how many camera alerts are generated.

Pulling down to refresh the display works as normal and all other settings and operations all appear to be working correctly for me.

All of my images are sent as jpg's so I haven't seen the issue with svg's. I also send url's which are also working.

The dev version is using the apps cache differently as it was showing about 9Mb cache while the original version was showing about 28Mb. I had cleared the cache of both of them earlier today.

For me the dev version has completely cured the issue I was having. Excellent work.

[IanQuilter]

This is a feature request, not a bug fix. I'm mentioning it now while you are working on changing the image handling code in case the new image handling method makes this easy to add.

At the moment it's not possible to do anything with an image shown in the Gotify app. It would occasionally be useful to be able to save the image and / or to zoom in on it. As it is now Gotify is very useful but if that could be added it would make Gotify much more versatile.

[jmattheis]

Please create a new ticket for this.