Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extra property to determine the content type #183

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Use extra property to determine the content type #183

merged 1 commit into from
Apr 13, 2019

Conversation

jmattheis
Copy link
Member

No description provided.

@jmattheis jmattheis requested a review from a team as a code owner April 5, 2019 17:53
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@69f1d72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     40           
  Lines             ?   1447           
  Branches          ?      0           
=======================================
  Hits              ?   1447           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f1d72...97e4d6e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@69f1d72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     40           
  Lines             ?   1447           
  Branches          ?      0           
=======================================
  Hits              ?   1447           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f1d72...97e4d6e. Read the comment docs.

eternal-flame-AD
eternal-flame-AD approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@eternal-flame-AD eternal-flame-AD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation should also be updated. Do we need to mention this in the swagger documentation?

@jmattheis jmattheis merged commit 2ad7409 into master Apr 13, 2019
@jmattheis jmattheis deleted the conditional-markdown branch April 13, 2019 08:14
@jmattheis jmattheis added this to the version+1 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternal-flame-AD eternal-flame-AD eternal-flame-AD approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jmattheis @eternal-flame-AD