Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extra property to determine the content type #183

Merged
merged 1 commit into from Apr 13, 2019

Conversation

2 participants
@jmattheis
Copy link
Member

commented Apr 5, 2019

No description provided.

@jmattheis jmattheis requested a review from gotify/committers as a code owner Apr 5, 2019

@jmattheis jmattheis force-pushed the conditional-markdown branch from 6ecd102 to 97e4d6e Apr 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@69f1d72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     40           
  Lines             ?   1447           
  Branches          ?      0           
=======================================
  Hits              ?   1447           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f1d72...97e4d6e. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@69f1d72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     40           
  Lines             ?   1447           
  Branches          ?      0           
=======================================
  Hits              ?   1447           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f1d72...97e4d6e. Read the comment docs.

@eternal-flame-AD
Copy link
Member

left a comment

The documentation should also be updated. Do we need to mention this in the swagger documentation?

@jmattheis jmattheis merged commit 2ad7409 into master Apr 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmattheis jmattheis deleted the conditional-markdown branch Apr 13, 2019

@jmattheis jmattheis added this to the version+1 milestone Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.