Solving #741- Add possibility to use GVariant in signal handler #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to gotk3#741 [WIP] Register GValue marshalers for: GSimpleAction, GAction, GPropertyAction Add marshaller for GVariant (WIP) Add: g_action_print_detailed_name() g_variant_parse()
|
Now i'm facing to another issue: Any help is welcome |
Add GVariant to 'goMarshal' This is a simple implementation and will need to be populated with all types supported by GVariant (with time)
|
Ok, it's done (i hope). |
g_variant_new_double() g_variant_get_double() And usage in goMarshal
hfmrow
changed the title
emad-elsaid
reviewed
Mar 6, 2021
| @@ -256,6 +256,33 @@ func goMarshal(closure *C.GClosure, retValue *C.GValue, | |||
| } else { | |||
| val = innerVal | |||
| } | |||
|
|
|||
| case *Variant: | |||
There was a problem hiding this comment.
I this a valid Go syntax? because under go 1.16 it produces this error:
# github.com/gotk3/gotk3/glib
../../go/pkg/mod/github.com/gotk3/gotk3@v0.5.3-0.20210305115817-fdbeed35eb7d/glib/glib.go:236:3: expected '}', found 'case'
../../go/pkg/mod/github.com/gotk3/gotk3@v0.5.3-0.20210305115817-fdbeed35eb7d/glib/glib.go:269:2: expected declaration, found rv
There was a problem hiding this comment.
This is indeed not valid syntax. I think I'll make a PR to fix this.
There was a problem hiding this comment.
It seems like something went wrong while merge conflicts were being solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #741 [WIP]
Register GValue marshalers for:
GSimpleAction
GAction
GPropertyAction
Add marshaller for GVariant (WIP)
Add: