Fix minor typos, linter warnings & add tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devkid This was about it I think, I changed some other test cases around but it doesn't add any value so I leave that for now |
alfredkrohmer
merged commit c0bbd53
into
goto-opensource:feature/istio-virtualservice-source
alfredkrohmer
pushed a commit
that referenced
this pull request
Jul 24, 2020
To run: provide token HETZNER_TOKEN in ENV set command line parameter --provider=hetzner
tvkit
pushed a commit
to tvkit/external-dns
that referenced
this pull request
Sep 9, 2020
Group equal DNS names into same endpoint
tvkit
pushed a commit
to tvkit/external-dns
that referenced
this pull request
Sep 9, 2020
tvkit
pushed a commit
to tvkit/external-dns
that referenced
this pull request
Sep 9, 2020
…ltradns_provider Feature/ultradns provider
tvkit
pushed a commit
to tvkit/external-dns
that referenced
this pull request
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.