Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tooltip): expose tooltip open property #42

Merged
merged 3 commits into from
May 14, 2024
Merged

feat(tooltip): expose tooltip open property #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d493bc
feat(tooltip): expose tooltip open property
abhishekv24 May 9, 2024
59df625
feat(tooltip): simplify implementation, added storybook for open by d…
abhishekv24 May 13, 2024
a9b563e
feat(Tooltip): refactor component
StewartJingga May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions packages/apsara-ui/src/Tooltip/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,40 @@
import React from "react";
import Tooltip, { TooltipProps } from "./Tooltip";

import Tooltip from "./Tooltip";

export default {
title: "Feedback/Tooltip",
component: Tooltip,
};

const Template = (args: TooltipProps) => <Tooltip {...args}>Tooltip</Tooltip>;
export const tooltip = Template.bind({});
tooltip.args = {
title: "tooltip",
placement: "right",
export const Basic = () => {
return (
<Tooltip title="This is tooltip content">
<span>Content Wrapped by Tooltip</span>
</Tooltip>
);
};

export const WithDefaultOpen = () => {
return (
<Tooltip title="I am open by default" defaultOpen>
<span>Content Wrapped by Tooltip</span>
</Tooltip>
);
};

export const ControlledState = () => {
const [open, setOpen] = React.useState(true);

return (
// @ts-ignore
<Tooltip title={(
<span>
This is tooltip content
<span style={{ marginLeft: '8px', cursor: 'pointer'}} onClick={() => setOpen(false)}>X</span>
</span>
)} open={open}>
<span>Content Wrapped by Tooltip</span>
</Tooltip>
);
};
31 changes: 16 additions & 15 deletions packages/apsara-ui/src/Tooltip/Tooltip.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import styled from "styled-components";
import * as RadixTooltip from "@radix-ui/react-tooltip";

export const TooltipContentWrapper = styled("span")`
.TooltipContent {
--tooltip-color: ${({ style }) => style?.color};
--tooltip-background-color: ${({ style }) => style?.backgroundColor};
color: var(--tooltip-color);
background-color: var(--tooltip-background-color);
padding: 4px 8px;
width: max-content;
max-width: 250px;
border-radius: 2px;
text-align: left;
font-size: 11px;
font-family: Roboto;
font-weight: 200;
}
export const TooltipContent = styled(RadixTooltip.Content)`
--tooltip-color: ${({ style }) => style?.color};
--tooltip-background-color: ${({ style }) => style?.backgroundColor};
color: var(--tooltip-color);
background-color: var(--tooltip-background-color);
padding: 4px 8px;
width: max-content;
max-width: 250px;
border-radius: 2px;
text-align: left;
font-size: 11px;
font-family: Roboto;
font-weight: 200;
background-color: #333;
color: white;

.TooltipArrow {
--tooltip-background-color: ${({ style }) => style?.backgroundColor};
Expand Down
33 changes: 18 additions & 15 deletions packages/apsara-ui/src/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,43 @@
import React, { HTMLAttributes } from "react";
import * as RadixTooltip from "@radix-ui/react-tooltip";
import { TooltipContentWrapper } from "./Tooltip.styles";

type RenderFunction = () => React.ReactNode;
import { TooltipContent } from "./Tooltip.styles";

export type TooltipPlacement = "left" | "right" | "top" | "bottom";

export type TooltipProps = {
title?: React.ReactNode | RenderFunction | string;
title?: React.ReactNode;
placement?: TooltipPlacement;
style?: React.CSSProperties;
defaultOpen?: boolean;
open?: boolean;
onOpenChange?: ((open: boolean) => void) | undefined;
delayDuration?: number;
avoidCollisions?: boolean;
} & HTMLAttributes<HTMLDivElement>;

const Tooltip = ({
title = "",
placement = "right",
style = { backgroundColor: "#333", color: "white" },
delayDuration = 100,
style,
children,
defaultOpen = false,
defaultOpen,
open,
onOpenChange,
avoidCollisions,
...props
}: TooltipProps) => {
return (
<RadixTooltip.Provider delayDuration={100}>
<RadixTooltip.Root defaultOpen={defaultOpen}>
<RadixTooltip.Provider delayDuration={delayDuration}>
<RadixTooltip.Root defaultOpen={defaultOpen} open={open} onOpenChange={onOpenChange}>
<RadixTooltip.Trigger asChild>
<span>{children}</span>
</RadixTooltip.Trigger>
<RadixTooltip.Portal>
<TooltipContentWrapper style={style}>
<RadixTooltip.Content className="TooltipContent" sideOffset={5} side={placement} {...props}>
{title}
<RadixTooltip.Arrow className="TooltipArrow" />
</RadixTooltip.Content>
</TooltipContentWrapper>
</RadixTooltip.Portal>
<TooltipContent className="TooltipContent" sideOffset={5} side={placement} style={style} avoidCollisions={avoidCollisions} {...props}>
{title}
<RadixTooltip.Arrow className="TooltipArrow" />
</TooltipContent>
</RadixTooltip.Root>
</RadixTooltip.Provider>
);
Expand Down