Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail view for comics/manga content #62

Closed
waz1500 opened this issue Jan 6, 2020 · 8 comments
Closed

Thumbnail view for comics/manga content #62

waz1500 opened this issue Jan 6, 2020 · 8 comments
Labels
enhancement New feature or request released

Comments

@waz1500
Copy link

waz1500 commented Jan 6, 2020

Running version which is v0.11.0-master in docker format.

Would it be possible for komga to display generated thumbnail views of all the images/content of a particular manga book? The feature could be in the "Read Book" part of the program and would allow a user to see the books image contents without manually moving the position marker left and right to quickly see it's contents.

@waz1500 waz1500 changed the title Thumbnail view for manga conent Thumbnail view for comics/manga content Jan 6, 2020
@muchtea
Copy link

muchtea commented Jan 6, 2020

This would be helpful with finding the correct page in long comics, where I can't remember the last page number I was on, but still have a pretty good visual memory of the last few pages I read.

@gotson
Copy link
Owner

gotson commented Jan 7, 2020

Interesting idea, but probably difficult to do. Thumbnail generation for a single page takes a few seconds, and even if we had the cpu time to generate all of those, storing all thumbnails would prove difficult.

Sending full size images to the client is possible, but usually very heavy, that would take very long to load.

@muchtea
Copy link

muchtea commented Jan 7, 2020

I agree that storing those thumbnails would not be a good idea unless there is a lot of space available or the comics are quite small.

I just had a look at lanraragi: https://github.com/Difegue/LANraragi
It seems the thumbnail view there is created simply by loading the full size images from the archive and displaying them smaller via css. I just tried that with a 500mb comic with 400 pages, which took about 10 to 20 seconds, but comic and application where on the same PC. I don't know how well this works through a network connection, especially for big files.

For smaller books this might however work well enough. A 10mb file with 40 images was pretty much instant thumbnails.

@gotson
Copy link
Owner

gotson commented Jan 7, 2020

I just tried the LANraragi demo, it takes ~30s to load all images over the network. I could add something similar to the webreader.

@gotson gotson added the enhancement New feature or request label Jan 7, 2020
@waz1500
Copy link
Author

waz1500 commented Jan 9, 2020

Just tried the development branch that features this. Great work on implementing this. I love how I can select any image on the thumb view and have it go straight to that page.

Still slow to load but not overbearing and I expect it to take a little longer during the first load. Am I right in that you have komga scale the image down to a set height x width? I don't think the quality needs to be that high in thumb view however. Would it not be possible to compress the thumbs on-the-fly somehow which may help with the load speed?

Thumbnails seem to take some time to generate the first time, but closing the book and loading it up again and clicking thumbnails, it seems to regenerate the thumbnails again, but slightly quicker with some thumbs already being filled. It should be instant if it's loaded them before or at least if it's stored them in a temporary folder and the container hasn't been restarted right?

I would love to have some sort of visual page numbering added in thumb view but right now you can see the page numbers by hovering with your mouse over an image.

@gotson
Copy link
Owner

gotson commented Jan 10, 2020

At the moment it's loading full size pages, which can be quite heavy both for the bandwidth but also for the browser to display.

I want to add on-the-fly resizing to reduce both the network load and the browser load in displaying those.

All images are cached by HTTP, so they are loaded only once.

I wanted to add a better tooltip when hovering the thumbnails, but Vuetify apparently doesn't support that 🤔

gotson added a commit that referenced this issue Jan 10, 2020
use on-the-fly thumbnails
add page number

related to #62
@waz1500
Copy link
Author

waz1500 commented Jan 11, 2020

I love the new changes for this feature!

The on-the-fly thumbnails has really made a difference in how fast komga generates them (almost instant in smaller books I've tested) and I'm loving the page number addition too. Thanks :)

@gotson gotson closed this as completed in ec06955 Jan 14, 2020
gotson pushed a commit that referenced this issue Jan 14, 2020
# [0.12.0](v0.11.0...v0.12.0) (2020-01-14)

### Bug Fixes

* **scanner:** compare file extensions with case insensitive ([91c9cdd](91c9cdd)), closes [#59](#59)
* **web reader:** conditional webp support ([ad21152](ad21152)), closes [#65](#65)

### Features

* **api:** add endpoints to get previous/next book of a book ([54f583f](54f583f))
* **api:** on-th-fly thumbnail generation for any page ([7167f3e](7167f3e))
* **web reader:** double page support ([77c9004](77c9004)), closes [#61](#61)
* **web reader:** remember fit and rtl ([78c181e](78c181e)), closes [#66](#66)
* **web reader:** thumbnails explorer ([ec06955](ec06955)), closes [#62](#62)
* better management of book analysis errors ([8c26a31](8c26a31))
@gotson
Copy link
Owner

gotson commented Jan 14, 2020

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

3 participants