Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround the problem of creating escodegen browser bundle (#489) #491

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Workaround the problem of creating escodegen browser bundle (#489) #491

merged 1 commit into from
Nov 24, 2015

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Nov 22, 2015

No description provided.

@ariya
Copy link
Contributor Author

ariya commented Nov 22, 2015

Argh, my sed trick doesn't work on Travis CI box. Hang in there while I'm improving my sed kungfu.

@ariya
Copy link
Contributor Author

ariya commented Nov 23, 2015

Now it's working after I switched to Perl.

The failure on Node.js 0.10 on Travis CI has nothing to do with this pull request. It fails because of JSHint (see https://travis-ci.org/gotwarlost/istanbul/jobs/92588195 for details). For whatever reason, some files didn't pass its linting:

> istanbul@0.4.0 pretest /home/travis/build/gotwarlost/istanbul
> jshint index.js lib/ test/ && ./download-escodegen-browser.sh

test/browser/test-browser-instrumentation.js: line 57, col 13, 'server' was used before it was defined.
test/browser/test-browser-instrumentation.js: line 13, col 5, 'server' is defined but never used.

test/cli/test-text-lcov-report.js: line 35, col 13, 'output' was used before it was defined.

gotwarlost added a commit that referenced this pull request Nov 24, 2015
Workaround the problem of creating escodegen browser bundle (#489)
@gotwarlost gotwarlost merged commit b8f2e8d into gotwarlost:master Nov 24, 2015
@ariya ariya deleted the fix-browser-test branch November 24, 2015 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants