Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip missing cards/dashboards in exposures #238

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Skip missing cards/dashboards in exposures #238

merged 3 commits into from
Mar 4, 2024

Conversation

dosnep
Copy link
Contributor

@dosnep dosnep commented Feb 28, 2024 •
edited by gouline
Loading

  • Fix: dbt-metabase now skips unreachable resources {card, dashboard, user} in case of requests.exceptions.HTTPError: 404 Client Error: Not Found for url

Closes #237

gouline
gouline requested changes Feb 28, 2024
View reviewed changes
Copy link
Owner

@gouline gouline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read CONTRIBUTING.md for local checks to run before committing, to avoid waiting for failed CI.

dbtmetabase/_exposures.py Outdated Show resolved Hide resolved
dbtmetabase/_exposures.py Outdated Show resolved Hide resolved
dbtmetabase/_exposures.py Outdated Show resolved Hide resolved
dbtmetabase/metabase.py Outdated Show resolved Hide resolved
dbtmetabase/metabase.py Outdated Show resolved Hide resolved
@dosnep
Copy link
Contributor Author

dosnep commented Mar 4, 2024

ommitting, to avoid waiting for failed CI.

CI has been tested locally (fmt-check and unit tests)

@gouline
Copy link
Owner

gouline commented Mar 4, 2024

Please read CONTRIBUTING.md carefully. You only ran the formatting check, you have to run all of them.

@gouline gouline changed the title In case of missing resource {dashboard, card, user}, dbt-metabase ski… Skip missing cards/dashboards in exposures Mar 4, 2024
@gouline gouline mentioned this pull request Mar 4, 2024
Closed
@gouline gouline changed the base branch from master to feat/exposure-missing-items March 4, 2024 23:13
@gouline gouline merged commit 83bb85f into gouline:feat/exposure-missing-items Mar 4, 2024
1 check failed
@gouline gouline mentioned this pull request Mar 4, 2024
Merged
gouline added a commit that referenced this pull request Mar 4, 2024
@gouline @dosnep
Fix PR 238 and add tests (#239)
4d40277 
* Skip missing cards/dashboards in exposures (#238)

* In case of missing resource {dashboard, card, user}, dbt-metabase skips it instead of raising an error.

* Rename get_[card, dashboard] to find_[card, dashboard], and remove duplicate return.

* Fix unit test, change all occurences for get_dashboard

---------

Co-authored-by: pierre dosne <pierre.dosne@fintecture.com>

* Fix type and format issues

* Add missing card to test

* Formatting and imports

---------

Co-authored-by: dosnep <dosnep@hotmail.fr>
Co-authored-by: pierre dosne <pierre.dosne@fintecture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouline gouline gouline requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exposure Extraction Error | In Case of Missing Cards in collection
2 participants
@dosnep @gouline