Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to exposures for excluding all unverified collection items #243

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

alex-float-on
Copy link
Contributor

@alex-float-on alex-float-on commented Mar 13, 2024

This PR introduces the ability to add an --exclude-unverified-cards flag to the exposures command in order to weed out exposures from cards that were not verified through metabase.

Note: I tried but could not figure out how to implement a unit test for this.

@alex-float-on alex-float-on marked this pull request as ready for review March 13, 2024 18:58
dbtmetabase/metabase.py Outdated Show resolved Hide resolved
dbtmetabase/metabase.py Outdated Show resolved Hide resolved
@alex-float-on alex-float-on force-pushed the exclude-unverified branch 3 times, most recently from a6fa4d0 to 7a904c7 Compare March 14, 2024 18:28
dbtmetabase/__main__.py Outdated Show resolved Hide resolved
dbtmetabase/_exposures.py Outdated Show resolved Hide resolved
dbtmetabase/_exposures.py Show resolved Hide resolved
gouline and others added 5 commits March 15, 2024 10:06
Co-authored-by: Mike Gouline <1960272+gouline@users.noreply.github.com>
Co-authored-by: Mike Gouline <1960272+gouline@users.noreply.github.com>
Copy link
Owner

@gouline gouline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making those changes!

I'll merge this on Monday, I want to release your other fix as a patch release (1.1.2) and this change will go in the next minor release (1.2.0).

@gouline gouline merged commit 7803ae2 into gouline:master Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants