[GOVCMS-4997] Introduced a script for DB restore #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveworley
requested changes
Aug 16, 2023
| BACKUP_FILE=$1 | ||
| echo "[info]: Importing backup file..." | ||
|
|
||
| if [[ $BACKUP_FILE == *".sql" ]]; then |
There was a problem hiding this comment.
I think this would be better if we staged it like:
- Extract the archive if required (reset BACKUP_FILE with the extracted location)
- Check the file size of the dump; if > 100m use mysql < 100m drush (or some other based on the testing).
Basically I think we should look to use raw mysql when we have large dbs to import, this will ultimately perform better than Drush will.
steveworley
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We currently operate under the assumption that the pre-deploy backup will be a restore point in the unlikely scenario where we notice data corruption or failures on a production site (eg. failed updates). Further to this assumption the process is assumed to just be a drush command to import the database again. The workflow and the limits of this process are neither tested nor documented.
Proposed solution
Introduce a db restore script as part of the scaffold tooling that is supported by functional and practical tests. The script should perform basic validation and allow one line restore command that accepts
.sql,.sql.gzand.tar.gzbackups.Usage
../govcms-db-restore [path-to-file]e.g.vendor/govcms/govcms-tooling/scripts/deploy/govcms-db-restore /tmp/backup.tar.gz