Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Update AUlabel selector to add margin-top for all HTMLInputElement #730

Merged
merged 14 commits into from
Apr 15, 2019

Conversation

azerella
Copy link
Contributor

@azerella azerella commented Apr 10, 2019

This requires publishing an update to NPM for the form component.

  • Update margin-top for form input element
  • Adds new prop for link-list react component
  • Fixes issue when bootstrapping on a fresh install where the react form component test tries to import a lib/js/react.es5.js file hasn't been built yet. - Use src/ instead

fixes #726

@azerella azerella added 🐛 bug Something isn’t working the way it should. enhancement New feature or request. labels Apr 10, 2019
@azerella azerella added this to the Sprint 127 milestone Apr 10, 2019
@sukhrajghuman
Copy link
Contributor

nice but i think we need to do a margin reset for inline labels

image

@azerella
Copy link
Contributor Author

azerella commented Apr 10, 2019

nice but i think we need to do a margin reset for inline labels

image

You mean add some margin: to the text on inline labels? The margin-top on the <input> is what we want

Copy link
Contributor Author

@azerella azerella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the jsdoc, then we are set 🚀

@azerella
Copy link
Contributor Author

azerella commented Apr 12, 2019

@sukhrajghuman Updated react prop jsdoc for link-list onClick event handler, ready for another review 💟

@azerella azerella merged commit 3081af9 into master Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn’t working the way it should. enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form - Add spacing to all input types above AUlabel
3 participants