(#14) fixing windows issues

Signed-off-by: Dominik Wilkowski <Hi@Dominik-Wilkowski.com>

packages/pancake-sass/CHANGELOG.md

@@ -6,6 +6,7 @@ Pancake Sass plugin
 
 ## Versions
 
+* [v1.1.0  - Optimized pancake for windows](v110)
 * [v1.0.11 - Added a comment into the generated Sass files](v1011)
 * [v1.0.10 - Fixed mixed js and Sass module bug](v1010)
 * [v1.0.9  - Cleaned logs](v109)
@@ -20,6 +21,12 @@ Pancake Sass plugin
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------
 
 
+## v1.1.0
+
+- Pancake now works on windows after escaping every path separator. Other operating system, other way to break code.
+	([#14](https://github.com/govau/pancake/issues/14))
+
+
 ## v1.0.11
 
 - Added a comment into the generated Sass files.

packages/pancake-sass/README.md

@@ -58,6 +58,7 @@ To run the tests make sure you go to the monorepo this package came from and clo
 
 ## Release History
 
+* v1.1.0  - Optimized pancake for windows
 * v1.0.11 - Added a comment into the generated Sass files
 * v1.0.10 - Fixed mixed js and Sass module bug
 * v1.0.9  - Cleaned logs

packages/pancake-sass/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@gov.au/pancake-sass",
-	"version": "1.0.11",
+	"version": "1.1.0",
 	"description": "A Pancake plugin to compile sass files.",
 	"keywords": [
 		"npm",

packages/pancake-sass/src/pancake.js

@@ -142,7 +142,7 @@ export const pancake = ( version, modules, settings, GlobalSettings, cwd ) => {
 				if( modulePackage.pancake['pancake-module'].sass['sass-versioning'] === true ) {
 					sassVersioning = true; //setting this if we encounter at least one module with sass-versioning enabled
 
-					const sassVersioningPath = Path.normalize(`${ cwd }/node_modules/sass-versioning/dist/_index.scss`);
+					const sassVersioningPath = Path.normalize(`${ cwd }/node_modules/sass-versioning/dist/_index.scss`).replace(/\\/g, "\\\\");
 
 					sass = `${ banner }` +
 						`/* ${ modulePackage.name } v${ modulePackage.version } */\n\n` +
@@ -195,7 +195,7 @@ export const pancake = ( version, modules, settings, GlobalSettings, cwd ) => {
 			const locationCSS = Path.normalize(`${ cwd }/${ SETTINGS.css.location }/${ SETTINGS.css.name }`);
 
 			if( sassVersioning === true ) {
-				const sassVersioningPath = Path.normalize(`${ cwd }/node_modules/sass-versioning/dist/_index.scss`);
+				const sassVersioningPath = Path.normalize(`${ cwd }/node_modules/sass-versioning/dist/_index.scss`).replace(/\\/g, "\\\\");
 
 				allSass = `${ banner }` +
 					`@import "${ sassVersioningPath }";\n\n` +

packages/pancake-sass/src/sass.js

@@ -126,7 +126,7 @@ export const GenerateSass = ( location, name, modules, npmOrg ) => {
 	const modulePath = GetPath( name, modules, baseLocation, npmOrg )
 	sass += `@import "${ modulePath }";\n`;
 
-	return sass;
+	return sass.replace(/\\/g, "\\\\"); // escape path for silly windows
 };
 
 
@@ -145,7 +145,7 @@ export const Sassify = ( location, settings, sass ) => {
 			data: sass,
 			indentType: 'tab', //this is how real developers indent!
 			outputStyle: settings.minified ? 'compressed' : 'expanded',
-		}, ( error, renered ) => {
+		}, ( error, generated ) => {
 			if( error ) {
 				Log.error(`Sass compile failed for ${ Style.yellow( location ) }`);
 
@@ -155,7 +155,7 @@ export const Sassify = ( location, settings, sass ) => {
 				Log.verbose(`Sass: Successfully compiled Sass for ${ Style.yellow( location ) }`);
 
 				Postcss([ Autoprefixer({ browsers: settings.browsers }) ])
-					.process( renered.css )
+					.process( generated.css )
 					.catch( error => reject( error ) )
 					.then( ( prefixed ) => {
 						if( prefixed ) {

packages/pancake/CHANGELOG.md

@@ -6,6 +6,7 @@ Pancake
 
 ## Versions
 
+* [v1.1.0  - Optimized pancake for windows](v110)
 * [v1.0.15 - Fixed mixed js and Sass module bug](v1015)
 * [v1.0.14 - Tweaked to facilitate syrup](v1013)
 * [v1.0.13 - Loading animation](v1013)
@@ -22,6 +23,12 @@ Pancake
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------
 
 
+## v1.1.0
+
+- Pancake now works on windows after escaping every path separator. Other operating system, other way to break code.
+	([#14](https://github.com/govau/pancake/issues/14))
+
+
 ## v1.0.15
 
 - Fixed a bug where pancake would fail when we mix modules that are only Sass and only Js.

packages/pancake/README.md

@@ -58,6 +58,7 @@ To run the tests make sure you go to the monorepo this package came from and clo
 
 ## Release History
 
+* v1.1.0  - Optimized pancake for windows
 * v1.0.15 - Fixed mixed js and Sass module bug
 * v1.0.14 - Tweaked to facilitate syrup
 * v1.0.13 - Loading animation

packages/pancake/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@gov.au/pancake",
-	"version": "1.0.15",
+	"version": "1.1.0",
 	"description": "Pancake is an utility to make working with npm modules for the frontend sweet and seamlessly.",
 	"keywords": [
 		"npm",

packages/pancake/src/files.js

@@ -72,15 +72,23 @@ export const CreateDir = ( dir ) => {
 	splitPath.reduce( ( path, subPath ) => {
 		let currentPath;
 
+		if( /^win/.test( process.platform ) && path === '' ) { // when using windows (post truth) at beginning of the path
+			path = './';                                         // we add the prefix to make sure it works on windows (yuck)
+		}
+
 		if( subPath != '.' ) {
 			currentPath = Path.normalize(`${ path }/${ subPath }`);
 
+			Log.verbose(`Checking if ${ Style.yellow( currentPath ) } exists`)
+
 			if( !Fs.existsSync( currentPath ) ){
 				try {
 					Fs.mkdirSync( currentPath );
+
+					Log.verbose(`Successfully ${ Style.yellow( currentPath ) } created`)
 				}
 				catch( error ) {
-					Log.error(`Pancake was unable to create the folder ${ Style.yellow( currentPath ) }`);
+					Log.error(`Pancake was unable to create the folder ${ Style.yellow( currentPath ) } for path ${ Style.yellow( dir ) }`);
 					Log.error( error );
 
 					process.exit( 1 );