Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Get pancake working in Windows #14

Closed
4 tasks done
dominikwilkowski opened this issue Feb 23, 2017 · 2 comments
Closed
4 tasks done

Get pancake working in Windows #14

dominikwilkowski opened this issue Feb 23, 2017 · 2 comments
Assignees
Labels
🐛 bug Something isn't working the way it should. module: pancake An issue or pull request related to pancake.

Comments

@dominikwilkowski
Copy link
Contributor

dominikwilkowski commented Feb 23, 2017

Windows is the new IE for node devs.
Areas that need attention from looking at initial tests:

  • The bash script in each module won't work naturally
  • Spawning new processes don't go down as they should. Need to look at that
  • The Sass paths need to be adapted to each os
  • Get folder creating to work
@dominikwilkowski dominikwilkowski added the 🐛 bug Something isn't working the way it should. label Feb 23, 2017
@dominikwilkowski dominikwilkowski added this to the UI-Kit 2.0 milestone Feb 23, 2017
@dominikwilkowski dominikwilkowski self-assigned this Feb 23, 2017
dominikwilkowski added a commit that referenced this issue Feb 23, 2017
Signed-off-by: Dominik Wilkowski <Hi@Dominik-Wilkowski.com>
@elisechant
Copy link

try cross-env npm plugin

@dominikwilkowski
Copy link
Contributor Author

dominikwilkowski commented Feb 23, 2017

That's all good. Thanks @elisechant

The only two problems I ad was getting rid of the bash script which is done already and spawning a child process which is easily done with:

const npmVersion = parseInt(Spawn('cmd.exe', ['/s','/c','npm', '-v']).stdout);

Sniffing OS is done with:

const isWin = /^win/.test(process.platform);

(can't use os.platform() as we support node 5)

dominikwilkowski added a commit that referenced this issue Feb 24, 2017
Signed-off-by: Dominik Wilkowski <Hi@Dominik-Wilkowski.com>
@dominikwilkowski dominikwilkowski added the module: pancake An issue or pull request related to pancake. label Feb 28, 2017
@dominikwilkowski dominikwilkowski removed this from the UI-Kit 2.0 milestone Mar 8, 2017
dominikwilkowski added a commit that referenced this issue May 4, 2017
Signed-off-by: Dominik Wilkowski <Hi@Dominik-Wilkowski.com>
@alex-page alex-page added this to Archive in Design System Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working the way it should. module: pancake An issue or pull request related to pancake.
Projects
None yet
Development

No branches or pull requests

2 participants