CS-2160- Add new component: Topic Takeaway #612
Conversation
| previouslink: /content-strategy/set-goals-measure-success/ | ||
| nextheader: "Do next: Remove content" | ||
| nexttext: Clean up phase | ||
| nextlink: /content-strategy/remove-content/ |
There was a problem hiding this comment.
Some of there are difficult to read maybe consider using _ to split words
There was a problem hiding this comment.
I would split these by previous and next. First column and second column can be confusing for users entering in content.
|
|
||
| .takeawayWhattodoLink { | ||
| padding-top: 20px; | ||
| } |
There was a problem hiding this comment.
We use BEM naming conventions. These will need to be fixed up as they are very inconsistent with the other class names conventions on the site. Make sure we don't use camel case it should be a combination of __ and - for BEM.
We also have a sass function for spacing uikit-space(). For now lets not use it as you will replace it when you update the uikit to the latest version however when writing out pixel values such as 14px and 20px that will cause problems in the future.
Whenever we use a colour value #666 make sure we use the correct variable in the $uikit-colour-Border.
There is also inconsistent white space which is killing me 😬 !!!! Lets make sure we use editorconfig and have consistent white space :)
| */ | ||
| const TopicTakeaway = ( page ) => { | ||
| return ( | ||
| <div className={ `uikit-body uikit-grid` } > |
There was a problem hiding this comment.
Because we don't use any variables this can be simplified to className="uikit-body uikit-grid"
JIRA CS-2160
https://govausites.atlassian.net/browse/CS-2160