Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for images with service requests #45

Merged
merged 15 commits into from
Feb 13, 2022
Merged

Add support for images with service requests #45

merged 15 commits into from
Feb 13, 2022

Conversation

pwalsh
Copy link
Member

@pwalsh pwalsh commented Jan 25, 2022

In progress

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #45 (d443b28) into main (3febfb4) will increase coverage by 0.10%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   89.31%   89.41%   +0.10%     
==========================================
  Files          60       64       +4     
  Lines        1235     1313      +78     
  Branches       74       89      +15     
==========================================
+ Hits         1103     1174      +71     
- Misses        132      139       +7     
Impacted Files Coverage Δ
src/core/open311/helpers.ts 100.00% <ø> (ø)
src/core/open311/repositories.ts 67.74% <ø> (ø)
...rations/09_servicerequestcomment_images_addedby.ts 63.63% <63.63%> (ø)
src/core/storage/helpers.ts 73.33% <73.33%> (ø)
src/core/service-requests/models.ts 84.09% <77.77%> (-0.12%) ⬇️
src/core/storage/routes.ts 89.47% <89.47%> (ø)
src/config/index.ts 96.49% <100.00%> (+0.57%) ⬆️
src/core/index.ts 100.00% <100.00%> (ø)
src/core/open311/routes.ts 97.61% <100.00%> (ø)
src/core/storage/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3febfb4...d443b28. Read the comment docs.

@pwalsh pwalsh mentioned this pull request Feb 7, 2022
@pwalsh pwalsh marked this pull request as ready for review February 13, 2022 08:46
@pwalsh pwalsh merged commit 64c45e9 into main Feb 13, 2022
@pwalsh pwalsh deleted the feature/images branch February 13, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants