Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/readable ticket #53

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Feature/readable ticket #53

merged 4 commits into from
Feb 22, 2022

Conversation

pwalsh
Copy link
Member

@pwalsh pwalsh commented Feb 21, 2022

@amirozer

This is ready for review.

There is a task that can be run to ensure public ids on existing databases, instead of adding it as a data migration - more flexible and easier with how data migrations work in Sequelize.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #53 (afc11f8) into main (0b87f7f) will decrease coverage by 0.57%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   89.00%   88.42%   -0.58%     
==========================================
  Files          63       64       +1     
  Lines        1300     1330      +30     
  Branches       90       94       +4     
==========================================
+ Hits         1157     1176      +19     
- Misses        143      154      +11     
Impacted Files Coverage Δ
src/core/service-requests/repositories.ts 100.00% <ø> (ø)
src/migrations/11_public_id_for_request.ts 66.66% <66.66%> (ø)
src/core/service-requests/helpers.ts 96.29% <100.00%> (+16.29%) ⬆️
src/core/service-requests/models.ts 85.10% <100.00%> (+1.01%) ⬆️
src/core/communications/helpers.ts 73.01% <0.00%> (-12.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b87f7f...afc11f8. Read the comment docs.

@pwalsh pwalsh requested a review from amirozer February 22, 2022 08:55
Copy link
Member

@amirozer amirozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pwalsh pwalsh merged commit 400383c into main Feb 22, 2022
@pwalsh pwalsh deleted the feature/readable-ticket-id branch February 22, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants